New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 718683 link

Starred by 1 user
Status: Fixed
Owner:
yllin@chromium.org
Closed: Jun 2017
Cc:
hungte@chromium.org
█ stimim@chromium.org
█ shunhsingou@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move _GetModuleSN related codes to device API

Project Member Reported by yllin@chromium.org, May 5 2017 
Discussed in CL:496006

Move _GetModuleSN related codes to device API.
Since these kinds of codes are highly dependent to the underlying HW, it's better to move it device API.

Reference: https://chromium-review.googlesource.com/c/496006/3/py/test/pytests/als_fixture.py#553
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/ecb5a4158d4ef9173d497ad7c436a26bbe449bde

commit ecb5a4158d4ef9173d497ad7c436a26bbe449bde
Author: Yilun Lin <yllin@google.com>
Date: Tue May 23 17:24:04 2017

device: Refactor camera APIs.

There are many redundant code between camera_fixture and als_fixture
tests. Refactor the camera APIs to increase reusability.

The CL does the following:
  - Create CameraDevice object, and move XXXCameraDevice into
    CameraReader object.
  - Add XXXCameraDevice object and add member functions
    IsValidSerialNumber/GetSerialNumber.
  - Add two CameraDevice derived classes: 'USBCamera', 'MIPICamera'.
  - Add two CameraDevice APIs: 'IsValidSerialNumber' and 'GetSerialNumber'.
  - CameraDevice object conatins a CameraReader object.
  - Migrate the serial number queries in als_fixture and camera_fixture to
    device APIs.

BUG= chromium:718683 
TEST=manual test als_fixture on eve.

Change-Id: I2227667b745616a81a0f375975eea56951f5fe9e
Reviewed-on: https://chromium-review.googlesource.com/497350
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org>

[modify] https://crrev.com/ecb5a4158d4ef9173d497ad7c436a26bbe449bde/py/test/utils/camera_utils.py
[modify] https://crrev.com/ecb5a4158d4ef9173d497ad7c436a26bbe449bde/py/test/pytests/camera_fixture_static/camera_fixture.js
[modify] https://crrev.com/ecb5a4158d4ef9173d497ad7c436a26bbe449bde/py/test/pytests/als_fixture.py
[modify] https://crrev.com/ecb5a4158d4ef9173d497ad7c436a26bbe449bde/py/test/pytests/als_fixture_static/als.params.sample
[modify] https://crrev.com/ecb5a4158d4ef9173d497ad7c436a26bbe449bde/py/test/pytests/camera_fixture_static/camera.params.sample
[modify] https://crrev.com/ecb5a4158d4ef9173d497ad7c436a26bbe449bde/py/test/pytests/als_fixture_static/als_fixture.js
[modify] https://crrev.com/ecb5a4158d4ef9173d497ad7c436a26bbe449bde/py/test/pytests/camera_fixture.py
[modify] https://crrev.com/ecb5a4158d4ef9173d497ad7c436a26bbe449bde/py/device/camera.py
[modify] https://crrev.com/ecb5a4158d4ef9173d497ad7c436a26bbe449bde/py/test/pytests/camera_fixture_static/camera_fixture.html
[modify] https://crrev.com/ecb5a4158d4ef9173d497ad7c436a26bbe449bde/py/test/pytests/als_fixture_static/als_fixture.html

Comment 2 by yllin@chromium.org, Jun 26 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment