New issue
Advanced search Search tips

Issue 718665 link

Starred by 2 users
Status: Fixed
Owner:
billorr@chromium.org
Closed: May 2017
Cc:
bajones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-XR



Sign in to add a comment

Expose Gamepad API instance for Cardboard button

Project Member Reported by ddorwin@chromium.org, May 5 2017 
The button on the Cardboard headset is only exposed via a simulated click event. WebVR authors should be able to use the same API regardless of the controller. For WebVR 1.1, this is the Gamepad API. Thus, we should expose a one-button 0-DoF gamepad.

This is also necessary before we can deprecate the click event ( issue 716571 ).

Note: The Daydream controller is already exposed as a gamepad.

Comment 1 by billorr@chromium.org, May 10 2017

Owner: billorr@chromium.org

Comment 2 by ddorwin@chromium.org, May 12 2017

Status: Started (was: Assigned)

Comment 3 by ddorwin@chromium.org, May 16 2017

Labels: -Restrict-View-Google
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ca5bedb3683ccf3db53fbad5bb93c60233c368b

commit 6ca5bedb3683ccf3db53fbad5bb93c60233c368b
Author: billorr <billorr@chromium.org>
Date: Tue May 23 18:21:18 2017

Expose Gamepad API instance for Cardboard button

This change exposes a gamepad with a single button, which is driven by the touch screen.

BUG= 718665 

Review-Url: https://codereview.chromium.org/2879973002
Cr-Commit-Position: refs/heads/master@{#473986}

[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/chrome/browser/android/vr_shell/vr_browser_interface.h
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/device/gamepad/gamepad_pad_state_provider.h
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/device/vr/BUILD.gn
[add] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/device/vr/android/gvr/cardboard_gamepad_data_fetcher.cc
[add] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/device/vr/android/gvr/cardboard_gamepad_data_fetcher.h
[add] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/device/vr/android/gvr/cardboard_gamepad_data_provider.h
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc
[modify] https://crrev.com/6ca5bedb3683ccf3db53fbad5bb93c60233c368b/device/vr/android/gvr/gvr_gamepad_data_provider.h

Comment 5 by billorr@chromium.org, May 23 2017

Status: Fixed (was: Started)

Comment 6 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment