Zoom resets when rotating orientation in the Device Toolbar
Reported by
irria...@gmail.com,
May 5 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.96 Safari/537.36 Steps to reproduce the problem: 1. Toggle Device Toolbar 2. Change zoom % to anything other than 100% 3. click the "Rotate" button What is the expected behavior? The zoom setting stays set at whatever it is set to before clicking "rotate" What went wrong? It resets back to 100% Did this work before? N/A Chrome version: 58.0.3029.96 Channel: stable OS Version: 10.0 Flash Version: If this is working as intended, please allow for the option to retain zoom% upon rotation. Thanks!
,
May 5 2017
Tested te issue on Windows 7 , mac os 10.12.3 and ubuntu 14.04 using chrome M58 #58.0.3029.96 and canary M60 #60.0.3090.0 and issue is reproduced This is a regression issue broken in M50 and is reproduced in all OS in all latest chrome channels. Using the per-revision bisect providing the bisect results, Good build:49.0.2623.0(Revision:369907). Bad build: 50.0.2624.0 (Revision:369950). You are probably looking for a change made after 369936 (known good), but no later than 369945 (first known bad). CHANGELOG URL: The script might not always return single CL as suspectas some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/4f99a3c216132ea5d9f0814be74b12787aaa7d73..a7098affaf89e105291df15457d7e728e7e1cf4f From the CL's above, assigning the issue to the concern owner Suspecting CL : https://chromium.googlesource.com/chromium/src/+/d0f00f7d6aedfa36a11b78dc93ab881c30f26553 @dgozman - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Review URL: https://codereview.chromium.org/1599603002 Thanks!
,
May 5 2017
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc7ddcb128b5ed469bf44edf34790804066871ce commit cc7ddcb128b5ed469bf44edf34790804066871ce Author: Erik Luo <luoe@chromium.org> Date: Tue Jan 23 02:00:52 2018 DevTools: add auto-adjust zoom checkbox to device mode This CL adds a checkbox to the zoom dropdown, allowing users to turn off 'Auto-adjust zoom', which scales the device to fit upon rotation and switching devices. It is on by default. Screenshot: https://imgur.com/a/Sov1K Bug: 718659 Change-Id: Ief5c3a2b84362b2125d51cd39bd5dc3e669a3e60 Reviewed-on: https://chromium-review.googlesource.com/858494 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531127} [modify] https://crrev.com/cc7ddcb128b5ed469bf44edf34790804066871ce/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-switching-devices-expected.txt [modify] https://crrev.com/cc7ddcb128b5ed469bf44edf34790804066871ce/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-switching-devices.js [modify] https://crrev.com/cc7ddcb128b5ed469bf44edf34790804066871ce/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by kavvaru@chromium.org
, May 5 2017