New issue
Advanced search Search tips

Issue 718655 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Support Product attribution on Timeline

Project Member Reported by alph@chromium.org, May 4 2017

Issue description

Add the product field for events associated with URLs.
 

Comment 4 by alph@chromium.org, May 12 2017

Summary: Support Product attribution on Timeline (was: Add the product field for events associated with URLs)
Project Member

Comment 5 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cc4ba79f53e6d0073d51343cbbbc4f1f5739952

commit 2cc4ba79f53e6d0073d51343cbbbc4f1f5739952
Author: alph <alph@chromium.org>
Date: Fri May 12 09:47:15 2017

DevTools: Tweak Group by Product

Show domain names for entries that have no product associated.
Color unmatched domain names with grey.

BUG= 718655 

Review-Url: https://codereview.chromium.org/2874273003
Cr-Commit-Position: refs/heads/master@{#471261}

[modify] https://crrev.com/2cc4ba79f53e6d0073d51343cbbbc4f1f5739952/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details-expected.txt
[modify] https://crrev.com/2cc4ba79f53e6d0073d51343cbbbc4f1f5739952/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Project Member

Comment 8 by bugdroid1@chromium.org, May 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca4cad869953b9ea4a2fa194a132526b2520e36b

commit ca4cad869953b9ea4a2fa194a132526b2520e36b
Author: alph <alph@chromium.org>
Date: Sat May 20 09:32:03 2017

DevTools: Use badges to render products in timeline details.

BUG= 718655 

Review-Url: https://codereview.chromium.org/2886393003
Cr-Commit-Position: refs/heads/master@{#473429}

[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links-expected.txt
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details-expected.txt
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details.html
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/Source/devtools/front_end/product_registry/badge.css
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/ca4cad869953b9ea4a2fa194a132526b2520e36b/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css

Project Member

Comment 9 by bugdroid1@chromium.org, May 25 2017

Project Member

Comment 10 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f51183e751e780ae7cd12d9782bd2bf104c8eeb

commit 4f51183e751e780ae7cd12d9782bd2bf104c8eeb
Author: Alexei Filippov <alph@chromium.org>
Date: Thu May 25 01:01:52 2017

DevTools: Enable "color by product" timeline experiment by default.

BUG= 718655 

Change-Id: Ie89d4c6b6ba6c7294e026e31b36102b8d36656f8
Reviewed-on: https://chromium-review.googlesource.com/514542
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474503}
[modify] https://crrev.com/4f51183e751e780ae7cd12d9782bd2bf104c8eeb/third_party/WebKit/Source/devtools/front_end/main/Main.js

Comment 11 by alph@chromium.org, Oct 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment