New issue
Advanced search Search tips

Issue 718654 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Custom Tabs: enableUrlBarHiding() only allows enabling urlbar hiding, but it's already enabled by default

Reported by ah...@mozilla.com, May 4 2017

Issue description

Steps to reproduce the problem:
1. Write app using Custom Tabs
2. Attempt to disable urlbar hiding
3. You have to set parameters using customTabsIntent.intent.putExtra(.....)

What is the expected behavior?
You can call something like CustomTabsIntent.Builder.disableUrlBarHiding()

What went wrong?
CustomTabsIntent.Builder only offers enableUrlBarHiding(), without any parameters, or methods to disable urlbar hiding:
https://github.com/GoogleChrome/custom-tabs-client/blob/master/customtabs/src/android/support/customtabs/CustomTabsIntent.java#L318

Chrome already enables urlbar hiding by default, see:
https://chromium.googlesource.com/chromium/src/+/4f9db38a7f90dedf1fa9046b897cdb59ed7dfce8/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java#107

If you explicitly want to disable urlbar hiding, then you need to manually set EXTRA_ENABLE_URLBAR_HIDING to false in the resulting Intent (you can't use the support library to do so).

I'm guessing the CustomTabsIntent.Builder API should be expanded to allow disabling urlbar hiding (the enableUrlBarHiding() call is redundant). Changing the default in chrome is likely to be more disruptive given that apps already assume that urlbar hiding enabled is the default (that might perhaps have been the original intention given the support library API?).

Did this work before? No 

Chrome version: all  Channel: dev
OS Version: 7.1.2
Flash Version:
 

Comment 1 by ah...@mozilla.com, May 5 2017

It would also be useful to document what the actual default is somewhere. Looking at the CustomTabsIntent.Builder API led me to believe that _not_ hiding is the default, until I actually looked Chrome's handling.
Components: UI>Browser>Mobile>CustomTabs
Status: WontFix (was: Unconfirmed)
***Bulk edit***

Closing due to inactivity, please feel free to reopen if needed.

Sign in to add a comment