Need more detailed OS and machine info in Telemetry |
||||
Issue description
On macOS at least, Telemetry doesn't provide the detailed OS version ("10.12.2", "10.12.4") -- only "sierra". This makes it difficult to look at logs and see what OS a given test machine is running. We should add this before we upgrade all the machines from 10.12.2 to 10.12.4 in Issue 718536 to make it easier to diagnose regressions.
Additionally, it was found that a recent refactoring that provided the model_name and model_version separately in the SystemInfo.getInfo DevTools API call caused Telemetry's logging information to be incomplete.
,
May 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb3375874e9439cb686c4bb8c109c1ce904ba83c commit bb3375874e9439cb686c4bb8c109c1ce904ba83c Author: kbr <kbr@chromium.org> Date: Sun May 07 06:09:07 2017 Unblock Catapult rolls. The addition of a new abstract method in telemetry.testing.fakes requires an override. BUG= 718635 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2864883002 Cr-Commit-Position: refs/heads/master@{#469898} [modify] https://crrev.com/bb3375874e9439cb686c4bb8c109c1ce904ba83c/content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py
,
May 7 2017
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc27f5ffc898c05ae0f3ca53cde799c4a01f3344 commit bc27f5ffc898c05ae0f3ca53cde799c4a01f3344 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Mon May 08 09:12:05 2017 Roll src/third_party/catapult/ ada8f7cc7..643994eea (5 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ada8f7cc7d7a..643994eea8e5 $ git log ada8f7cc7..643994eea --date=short --no-merges --format='%ad %ae %s' 2017-05-07 benjhayden Enable eslint no-var and prefer-const. 2017-05-05 simonhatch Dashboard - Use guid in /add_histograms_queue. 2017-05-05 eakuefner [TBMv2] Set guids when deserializing diagnostics 2017-05-05 benjhayden Simplify tr.b.Timing. 2017-05-05 kbr Add PlatformBackend.GetOSVersionDetailString and log it in Browser. Created with: roll-dep src/third_party/catapult BUG= 718635 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id42db36e34289b27f3b2f26434d07a56f3d60238 Reviewed-on: https://chromium-review.googlesource.com/498066 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469934} [modify] https://crrev.com/bc27f5ffc898c05ae0f3ca53cde799c4a01f3344/DEPS
,
May 8 2017
Working on exposing Chrome's command line, too. DevTools CL: https://codereview.chromium.org/2868783003/ Telemetry CL: https://codereview.chromium.org/2871803002
,
May 16 2017
,
May 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebbd3a5c5eee3ec38736e60c53f2ea1bc3faed6c commit ebbd3a5c5eee3ec38736e60c53f2ea1bc3faed6c Author: kbr <kbr@chromium.org> Date: Wed May 17 10:55:21 2017 Add command_line to SystemInfo data structure. The real browser command line is often needed for debugging purposes. Expose it in DevTools' experimental SystemInfo data structure. BUG= 718635 Review-Url: https://codereview.chromium.org/2868783003 Cr-Commit-Position: refs/heads/master@{#472415} [modify] https://crrev.com/ebbd3a5c5eee3ec38736e60c53f2ea1bc3faed6c/content/browser/devtools/protocol/system_info_handler.cc [modify] https://crrev.com/ebbd3a5c5eee3ec38736e60c53f2ea1bc3faed6c/third_party/WebKit/Source/core/inspector/browser_protocol.json
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f8d636e0a218db1d2b6bee09250566a89eaa02c commit 6f8d636e0a218db1d2b6bee09250566a89eaa02c Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Thu May 18 07:51:55 2017 Roll src/third_party/catapult/ d76621c5e..dd9db5d3f (5 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d76621c5ec84..dd9db5d3f658 $ git log d76621c5e..dd9db5d3f --date=short --no-merges --format='%ad %ae %s' 2017-05-17 kbr Pass False for fromSurface argument to Page.captureScreenshot. 2017-05-17 rnephew [Telemetry] Rename DisableBenchmark to PermenantlyDisableBenchmark in StoryExpectations 2017-05-17 sullivan Fix typo in api documentation 2017-05-17 kbr Expose browser command line via SystemInfo. 2017-05-17 sullivan Add documenation on the alert list JSON format. Created with: roll-dep src/third_party/catapult BUG= 714058 ,711065, 718635 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7d0e18ec4ac4032ca270f38f6f406bf1357a33f0 Reviewed-on: https://chromium-review.googlesource.com/508260 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#472727} [modify] https://crrev.com/6f8d636e0a218db1d2b6bee09250566a89eaa02c/DEPS
,
May 18 2017
This is landed and working. See for example: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.gpu%2FMac_Retina_Release__AMD_%2F6776%2F%2B%2Frecipes%2Fsteps%2Fwebgl_conformance_tests_on_ATI_GPU_on_Mac_Retina%2F0%2Fstdout Log contains: (INFO) 2017-05-18 09:13:26,711 browser._LogBrowserInfo:118 OS: mac sierra (INFO) 2017-05-18 09:13:26,736 browser._LogBrowserInfo:121 Detailed OS version: 10.12.4 16E195 (INFO) 2017-05-18 09:13:26,798 browser._LogBrowserInfo:125 Model: MacBookPro 11.5 (INFO) 2017-05-18 09:13:26,799 browser._LogBrowserInfo:127 Browser command line: /b/s/w/ir/out/Release/Chromium.app/Contents/MacOS/Chromium --disable-domain-blocking-for-3d-apis --ignore-autoplay-restrictions --disable-gpu-process-crash-limit --test-type=gpu --enable-experimental-canvas-features --js-flags=--expose-gc --enable-logging=stderr --enable-net-benchmarking --metrics-recording-only --no-default-browser-check --no-first-run --enable-gpu-benchmarking --disable-background-networking --proxy-server=socks://localhost:52272 --ignore-certificate-errors --disable-component-extensions-with-background-pages --disable-default-apps --disable-search-geolocation-disclosure --remote-debugging-port=0 --enable-crash-reporter-for-testing --disable-component-update --window-size=1280,1024 --user-data-dir=/b/s/w/it5KLajk/tmp17nVXc --flag-switches-begin --flag-switches-end about:blank (INFO) 2017-05-18 09:13:26,799 browser._LogBrowserInfo:130 GPU device 0: VENDOR = 0x1002 (ATI), DEVICE = 0x6821 (INFO) 2017-05-18 09:13:26,799 browser._LogBrowserInfo:130 GPU device 1: VENDOR = 0x8086 (Intel), DEVICE = 0xd26 ... |
||||
►
Sign in to add a comment |
||||
Comment 1 by nedngu...@google.com
, May 4 2017