New issue
Advanced search Search tips

Issue 718628 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: ----



Sign in to add a comment

base_unittests failing on chromium.memory/Mac ASan 64 Tests (1)

Project Member Reported by rjkroege@chromium.org, May 4 2017

Issue description

base_unittests failing on chromium.memory/Mac ASan 64 Tests (1)

Builders failed on: 
- Mac ASan 64 Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29


The problem:

[756:12551:0504/134809.395246:112544450082:FATAL:native_stack_sampler_mac.cc(170)] Check failed: std::string(name) == std::string("/usr/lib/system/libsystem_kernel.dylib") (/b/swarm_slave/w/ir/out/Release/libclang_rt.asan_osx_dynamic.dylib vs. /usr/lib/system/libsystem_kernel.dylib)

When running under ASAN. Probably needs something smarter.
 
smarter about path matching that is.
work-around is in the CQ.


Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fc72beca8ade08e0dff7ef5bb555f6fee9656fd

commit 6fc72beca8ade08e0dff7ef5bb555f6fee9656fd
Author: rjkroege <rjkroege@chromium.org>
Date: Thu May 04 23:25:24 2017

Work-around ASAN problem in profiler

ASAN wraps the kernel dylib on mac. Special case this to avoid tripping
a DCHECK.

BUG=718628
TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2859303002
Cr-Commit-Position: refs/heads/master@{#469515}

[modify] https://crrev.com/6fc72beca8ade08e0dff7ef5bb555f6fee9656fd/base/profiler/native_stack_sampler_mac.cc

Cc: rjkroege@chromium.org
Labels: Pri-1
Thanks rjkroege! Unfortunately a few tests are still failing:

[ RUN      ] StackSamplingProfilerTest.Alloca
../../base/profiler/stack_sampling_profiler_unittest.cc:766: Failure
Value of: end_frame != sample.frames.end()
  Actual: false
Expected: true
Function at 0x1045a3fe0 was not found in stack:
0x0x7fff8dace716 /usr/lib/system/libsystem_kernel.dylib
[  FAILED  ] StackSamplingProfilerTest.Alloca (4 ms)
[ RUN      ] StackSamplingProfilerTest.Basic
../../base/profiler/stack_sampling_profiler_unittest.cc:684: Failure
Value of: loc != sample.frames.end()
  Actual: false
Expected: true
Function at 0x1045a3fe0 was not found in stack:
0x0x7fff8dace716 /usr/lib/system/libsystem_kernel.dylib
[  FAILED  ] StackSamplingProfilerTest.Basic (7 ms)
[ RUN      ] StackSamplingProfilerTest.UnloadedLibrary
../../base/profiler/stack_sampling_profiler_unittest.cc:576: Failure
Value of: end_frame != sample.frames.end()
  Actual: false
Expected: true
Function at 0x10b472fe0 was not found in stack:
0x0x7fff8dace716 /usr/lib/system/libsystem_kernel.dylib
[  FAILED  ] StackSamplingProfilerTest.UnloadedLibrary (5 ms)
[ RUN      ] StackSamplingProfilerTest.OtherLibrary
../../base/profiler/stack_sampling_profiler_unittest.cc:1401: Failure
Value of: other_library_frame != sample.frames.end()
  Actual: false
Expected: true
Function at 0x10b48eeb0 was not found in stack:
0x0x7fff8dace716 /usr/lib/system/libsystem_kernel.dylib
[  FAILED  ] StackSamplingProfilerTest.OtherLibrary (7 ms)
Project Member

Comment 5 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20352c4f2055a99e8df8b0ab75b8b54f79cebc77

commit 20352c4f2055a99e8df8b0ab75b8b54f79cebc77
Author: johnme <johnme@chromium.org>
Date: Fri May 05 14:51:30 2017

Disable 4 failing StackSamplingProfilerTest tests on macOS ASAN.

The {Alloca,Basic,UnloadedLibrary,OtherLibrary} tests from
StackSamplingProfilerTest are failing since
https://codereview.chromium.org/2848683006 because ASAN wraps the kernel
dylib on macOS.

This patch disables them for now on macOS ASAN.

BUG=718628
TBR=avi@chromium.org
NOTRY=true
SKIPTREECHECKS=true

Review-Url: https://codereview.chromium.org/2863133002
Cr-Commit-Position: refs/heads/master@{#469648}

[modify] https://crrev.com/20352c4f2055a99e8df8b0ab75b8b54f79cebc77/base/profiler/stack_sampling_profiler_unittest.cc

Labels: -Sheriff-Chromium

Sign in to add a comment