New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718625 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Shortcuts are removed when package is updated

Project Member Reported by khmel@chromium.org, May 4 2017

Issue description

Shortcuts should not be removed on ARC package update.
Inner bug: b/34749664
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9984205426901dece21078e03eb68d4c7ef1fa07

commit 9984205426901dece21078e03eb68d4c7ef1fa07
Author: khmel <khmel@chromium.org>
Date: Thu May 04 23:57:44 2017

arc: Fix removing shortcuts on package update.

TEST=unit tests extented. Manually, updated test app via adb and
     its shorcuts were left in app launcher
BUG= 718625 
BUG=b/34749664

Review-Url: https://codereview.chromium.org/2860243002
Cr-Commit-Position: refs/heads/master@{#469529}

[modify] https://crrev.com/9984205426901dece21078e03eb68d4c7ef1fa07/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/9984205426901dece21078e03eb68d4c7ef1fa07/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/9984205426901dece21078e03eb68d4c7ef1fa07/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Comment 2 by khmel@chromium.org, May 5 2017

Cc: gkihumba@chromium.org
Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 6 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/765f43f5304b773f50c44c69675a1d956e3784af

commit 765f43f5304b773f50c44c69675a1d956e3784af
Author: khmel <khmel@chromium.org>
Date: Mon May 08 21:50:41 2017

[Merge M59] arg: Fix removing shortcuts on package update.

TEST=unit tests extented. Manually, updated test app via adb and
     its shorcuts were left in app launcher
BUG= 718625 
BUG=b/34749664
TBR=xiyuan@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2860243002
Cr-Commit-Position: refs/heads/master@{#469529}
(cherry picked from commit 9984205426901dece21078e03eb68d4c7ef1fa07)

Review-Url: https://codereview.chromium.org/2869973002
Cr-Commit-Position: refs/branch-heads/3071@{#468}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/765f43f5304b773f50c44c69675a1d956e3784af/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/765f43f5304b773f50c44c69675a1d956e3784af/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/765f43f5304b773f50c44c69675a1d956e3784af/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Comment 5 by khmel@chromium.org, May 8 2017

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment