New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718620 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Need option to include XRefs only from test code

Project Member Reported by lukasza@chromium.org, May 4 2017

Issue description

Repro steps:

Try to see if there is an existing RenderFrameCreatedWaiter class:
1. Search for overrides of content::WebContentsObserver::RenderFrameCreated
2. See that there is quite a few.
3. Try to filter out non-test overrides.

Expected behavior: There is a way to filter out non-test XRefs

Actual behavior: "Xref Filter" has only "Exclude tests" checkbox, but there is no symmetrical "Exclude non-tests".

Maybe instead of having "Exclude foo" checkboxes, we should have checkboxes (by default all checked) for:
- Include test code
- Include product (i.e. non-test) code
- Include generated code
- Include commiteed (i.e. non-generated) code
 
Cc: dsansome@chromium.org

Comment 2 by emso@chromium.org, May 17 2017

Labels: Xrefs
Owner: emso@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by emso@chromium.org, Nov 2 2017

Cc: -dsansome@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 2

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Archived (was: Untriaged)

Sign in to add a comment