New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718608 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tests Hang Due To EME Permissions Prompt

Project Member Reported by vaage@google.com, May 4 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36

Steps to reproduce the problem:
1. Open https://shaka-player-demo.appspot.com in Chrome on Android
2. See the EME Permission Prompt

What is the expected behavior?
We need a way to bypass this prompt so we can automate our tests. We need a way to whitelist urls do that the prompt will be bypassed when we run our tests.

What went wrong?
Our tests hang due to the EME permissions prompt.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 58.0.3029.81  Channel: n/a
OS Version: OS X 10.12.4
Flash Version: 

We already have an Android device in our test lab, but it is disabled by default.  Tests hang due to the EME permissions prompt, which cannot be disabled by command-line switch.

There used to be such a switch, but it was removed.  See:

https://groups.google.com/a/google.com/d/topic/encrypted-media/Q6NsYX9_b_U/discussion
https://codereview.chromium.org/1153543015/
 

Comment 1 by vaage@google.com, May 4 2017

We have a change in review at https://codereview.chromium.org/2816773002/
Cc: joeyparrish@chromium.org xhw...@chromium.org
Labels: Needs-Triage-M58
Labels: TE-NeedsTriageHelp
Cc: -joeyparrish@chromium.org vaage@google.com
Labels: -OS-Mac -TE-NeedsTriageHelp -Needs-Triage-M58 M-60 OS-Android OS-Chrome
Owner: joeyparrish@chromium.org
Status: Assigned (was: Unconfirmed)
vaage@ is working on this. Unfortunately I can't assign this issue to him since he's not a "project memeber". Assign to joeyparrish@ to remove teh NeedsTriage labels.
Components: Internals>Media>Encrypted
Project Member

Comment 7 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae33ffef0abd60c2fb050dbbadafae3345c568a

commit 2ae33ffef0abd60c2fb050dbbadafae3345c568a
Author: vaage <vaage@google.com>
Date: Fri May 12 00:39:49 2017

Added switch for bypassing protected media identifier permission

For testing protected content we need to bypass the prompt
for permission to play protected content. This change add the
switch --unsafely-allow-protected-media-identifier-for-domain
which will disable the info bar when protected content needs
permission when playing from localhost.

BUG= 718608 

Review-Url: https://codereview.chromium.org/2816773002
Cr-Commit-Position: refs/heads/master@{#471150}

[modify] https://crrev.com/2ae33ffef0abd60c2fb050dbbadafae3345c568a/chrome/browser/media/protected_media_identifier_permission_context.cc
[modify] https://crrev.com/2ae33ffef0abd60c2fb050dbbadafae3345c568a/chrome/browser/media/protected_media_identifier_permission_context.h
[add] https://crrev.com/2ae33ffef0abd60c2fb050dbbadafae3345c568a/chrome/browser/media/protected_media_identifier_permission_context_unittest.cc
[modify] https://crrev.com/2ae33ffef0abd60c2fb050dbbadafae3345c568a/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/2ae33ffef0abd60c2fb050dbbadafae3345c568a/chrome/test/BUILD.gn
[modify] https://crrev.com/2ae33ffef0abd60c2fb050dbbadafae3345c568a/media/base/media_switches.cc
[modify] https://crrev.com/2ae33ffef0abd60c2fb050dbbadafae3345c568a/media/base/media_switches.h

Labels: Merge-Request-59
Project Member

Comment 9 by sheriffbot@chromium.org, May 12 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, May 12 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/969d28d0e04dcf8a76842a634d9c79baa5b3286e

commit 969d28d0e04dcf8a76842a634d9c79baa5b3286e
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Fri May 12 21:26:19 2017

(merge m59) Added switch for bypassing protected media identifier permission

For testing protected content we need to bypass the prompt
for permission to play protected content. This change add the
switch --unsafely-allow-protected-media-identifier-for-domain
which will disable the info bar when protected content needs
permission when playing from localhost.

BUG= 718608 

Review-Url: https://codereview.chromium.org/2816773002
Cr-Original-Commit-Position: refs/heads/master@{#471150}
Review-Url: https://codereview.chromium.org/2881843003 .
Cr-Commit-Position: refs/branch-heads/3071@{#539}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/969d28d0e04dcf8a76842a634d9c79baa5b3286e/chrome/browser/media/protected_media_identifier_permission_context.cc
[modify] https://crrev.com/969d28d0e04dcf8a76842a634d9c79baa5b3286e/chrome/browser/media/protected_media_identifier_permission_context.h
[add] https://crrev.com/969d28d0e04dcf8a76842a634d9c79baa5b3286e/chrome/browser/media/protected_media_identifier_permission_context_unittest.cc
[modify] https://crrev.com/969d28d0e04dcf8a76842a634d9c79baa5b3286e/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/969d28d0e04dcf8a76842a634d9c79baa5b3286e/chrome/test/BUILD.gn
[modify] https://crrev.com/969d28d0e04dcf8a76842a634d9c79baa5b3286e/media/base/media_switches.cc
[modify] https://crrev.com/969d28d0e04dcf8a76842a634d9c79baa5b3286e/media/base/media_switches.h

Status: Fixed (was: Assigned)

Comment 12 Deleted

Sign in to add a comment