New issue
Advanced search Search tips

Issue 718595 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
dmu...@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 770862


Sign in to add a comment

Remove ToWireString memcpy's and even size requirement

Project Member Reported by dmu...@chromium.org, May 4 2017 
We memcpy every single time we convert ssv we pad the ending if it's not even. This is (I think) because we sometimes rely on string16 bytes.

We should remove this requirement so we no longer have to memcpy every single time this is called.

https://cs.chromium.org/chromium/src/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc?dr=CSs&g=0&l=293

Comment 1 by jbroman@chromium.org, May 4 2017

Components: -Internals>Core
Yup, it's on my to-do list. Just have to go around and kill every place that stores it in a 16-bit string.
Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f18f120c6b5ebef92bd05d50dd60935185daced9

commit f18f120c6b5ebef92bd05d50dd60935185daced9
Author: jbroman <jbroman@chromium.org>
Date: Mon May 08 16:00:18 2017

Expose SerializedScriptValue data without requiring a copy.

This view does not pad to an even size.

To begin with, use this to implement internals.serializeObject.

BUG=718595

Review-Url: https://codereview.chromium.org/2855123009
Cr-Commit-Position: refs/heads/master@{#469995}

[modify] https://crrev.com/f18f120c6b5ebef92bd05d50dd60935185daced9/third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/cloneKey-expected.txt
[modify] https://crrev.com/f18f120c6b5ebef92bd05d50dd60935185daced9/third_party/WebKit/LayoutTests/crypto/subtle/aes-gcm/cloneKey-expected.txt
[modify] https://crrev.com/f18f120c6b5ebef92bd05d50dd60935185daced9/third_party/WebKit/LayoutTests/crypto/subtle/ecdh/cloneKey-expected.txt
[modify] https://crrev.com/f18f120c6b5ebef92bd05d50dd60935185daced9/third_party/WebKit/LayoutTests/crypto/subtle/ecdsa/cloneKey-expected.txt
[modify] https://crrev.com/f18f120c6b5ebef92bd05d50dd60935185daced9/third_party/WebKit/LayoutTests/crypto/subtle/hkdf/cloneKey-expected.txt
[modify] https://crrev.com/f18f120c6b5ebef92bd05d50dd60935185daced9/third_party/WebKit/LayoutTests/crypto/subtle/hmac/cloneKey-expected.txt
[modify] https://crrev.com/f18f120c6b5ebef92bd05d50dd60935185daced9/third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/cloneKey-expected.txt
[modify] https://crrev.com/f18f120c6b5ebef92bd05d50dd60935185daced9/third_party/WebKit/LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5/cloneKey-expected.txt
[modify] https://crrev.com/f18f120c6b5ebef92bd05d50dd60935185daced9/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.h
[modify] https://crrev.com/f18f120c6b5ebef92bd05d50dd60935185daced9/third_party/WebKit/Source/core/testing/Internals.cpp

Comment 3 by mek@chromium.org, Oct 2 2017

Blockedon: 770862
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 3

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by jsb...@chromium.org, Oct 3

Description: Show this description

Comment 6 by jsb...@chromium.org, Oct 3

Summary: Remove ToWireString memcpy's and even size requirement (was: Remove ToWireBytes memcpy's and even size requirement)

Comment 7 by jsb...@chromium.org, Oct 3

Components: -Blink>Storage -Blink>Messaging Blink>Bindings
Status: Available (was: Untriaged)
Only used by History via via WebSerializedScriptValue::ToString now?

Comment 8 by jsb...@chromium.org, Oct 3

Labels: -Hotlist-Recharge-Cold
►

Sign in to add a comment