sys-boot/loonix-u-boot broken (comments added to linker script) |
||||
Issue description
Chrome Version : 58.0.3029.81
OS Version:
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:
Reference is b/37998203
What steps will reproduce the problem?
1. ./setup_board --board=lasilla-sky
2. emerge-lasilla-sky sys-boot/loonix-u-boot
What is the expected result?
It should build OK, but doesn't.
This seems to be related to the chromium header that now appears in the linker script.
I can reproduce it manually like this:
(cr) ((a6692e0...)) icoolidge@grimace ~/trunk/src/scripts $ /usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.25.51/ld.bfd.real /build/lasilla-sky/tmp/portage/sys-boot/loonix-u-boot-2015.04-r6/work/build/spl/u-boot-spl.lds
/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.25.51/ld.bfd.real:/build/lasilla-sky/tmp/portage/sys-boot/loonix-u-boot-2015.04-r6/work/build/spl/u-boot-spl.lds: file format not recognized; treating as linker script
/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.25.51/ld.bfd.real:/build/lasilla-sky/tmp/portage/sys-boot/loonix-u-boot-2015.04-r6/work/build/spl/u-boot-spl.lds:1: syntax error
When I edit the file to remove the // comments at the top, it runs further with no syntax errors.
(cr) ((a6692e0...)) icoolidge@grimace ~/trunk/src/scripts $ /usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.25.51/ld.bfd.real /build/lasilla-sky/tmp/portage/sys-boot/loonix-u-boot-2015.04-r6/work/build/spl/u-boot-spl.lds
/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.25.51/ld.bfd.real: warning: /build/lasilla-sky/tmp/portage/sys-boot/loonix-u-boot-2015.04-r6/work/build/spl/u-boot-spl.lds contains output sections; did you forget -T?
/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.25.51/ld.bfd.real: cannot find arch/arm/cpu/armv7/start.o
UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36
,
May 4 2017
,
May 4 2017
There has been no change to sys-devel/binutils recently (last update was on 2016-11-18). I've been working recently on upgrading to binutils 2.27, but that's not committed yet. Any change to sys-boot/loonix-u-boot sources that added these comments?
,
May 4 2017
,
May 4 2017
We added the license comment to a c header file, and somehow it was leaking into the linker script. What.
,
May 4 2017
Sorry for the noise. I didn't fathom how my change could cause this.
,
May 4 2017
Sorry for the noise. I didn't fathom how my change could cause this.
,
May 4 2017
Just a passing thought/comment: You mentioned removing lines starting with '//', and you also mentioned that they were from a C header file. I did a code search on some other u-boot-spl.lds files, and they have comments at the top, but the comments are C-style comments: /* commment goes here */ Is there any chance that using C-style comments will fix your issue? |
||||
►
Sign in to add a comment |
||||
Comment 1 by icoolidge@chromium.org
, May 4 2017