New issue
Advanced search Search tips

Issue 718578 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Content size incorrect when transitioning from webVR into VR Shell

Project Member Reported by mthiesse@chromium.org, May 4 2017

Issue description

Repro steps:
0. Enable Chrome VR
1. Navigate to webVR page
2. Enter VR
3. Call vrDisplay.exitPresent()
(Should now be in Chrome VR)
4. Note content size is incorrect (when compared to entering Chrome VR and navigating to the same webVR page).

 
Owner: billorr@chromium.org
Status: start (was: Available)
Taking a look.  Interestingly, I'm seeing an apparent freeze when I try to exit webvr.
Status: Started (was: start)
Status: WontFix (was: Started)
I'm not seeing this repro, so resolving "won't fix" - the content size (both quad, and apparent resolution/scaling) seem equivalent whether I enter webvr then exit presentation, or get to the site by navigating in vr.
Status: Assigned (was: WontFix)
Saw this.  went to a webvr site, hit the app button to exit presentation, and then navigated back to the webvr samples page.  Scaling was off.
My repro:
1. went to webvr.info's sample page
2. navigated to the presentation sample
3. clicked "enter vr" to start presentation
4. hit the app button on the controller
5. navigated back while still in vr browsing

expected: correctly sized readable text.
actual: the entire page was scaled down so text was unreadable
Labels: M-60
It looks like app button click (and exiting WebVR through exit present) don't setContentCssSize, and they should.  Sent out a cr.
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/625bfbd862c294832d217c35245e7b61a1e6ccfb

commit 625bfbd862c294832d217c35245e7b61a1e6ccfb
Author: billorr <billorr@chromium.org>
Date: Wed May 31 22:48:15 2017

VR: Content size incorrect when transitioning from webVR into VR Shell

The issue here is we are setting the virtual display's size when we
enter WebVR, but not when we exit it to VrShell.  This means that
content is incorrectly sized.

The fix simply sets the virtual display's size when we exit WebVR to VrShell.

BUG= 718578 

Review-Url: https://codereview.chromium.org/2906173002
Cr-Commit-Position: refs/heads/master@{#476074}

[modify] https://crrev.com/625bfbd862c294832d217c35245e7b61a1e6ccfb/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Project Member

Comment 10 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/625bfbd862c294832d217c35245e7b61a1e6ccfb

commit 625bfbd862c294832d217c35245e7b61a1e6ccfb
Author: billorr <billorr@chromium.org>
Date: Wed May 31 22:48:15 2017

VR: Content size incorrect when transitioning from webVR into VR Shell

The issue here is we are setting the virtual display's size when we
enter WebVR, but not when we exit it to VrShell.  This means that
content is incorrectly sized.

The fix simply sets the virtual display's size when we exit WebVR to VrShell.

BUG= 718578 

Review-Url: https://codereview.chromium.org/2906173002
Cr-Commit-Position: refs/heads/master@{#476074}

[modify] https://crrev.com/625bfbd862c294832d217c35245e7b61a1e6ccfb/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Labels: Merge-Request-60
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 1 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 2 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/079395cb4a1ae3e6267aada372111300602ceb2e

commit 079395cb4a1ae3e6267aada372111300602ceb2e
Author: billorr <billorr@chromium.org>
Date: Fri Jun 02 00:55:49 2017

VR: Content size incorrect when transitioning from webVR into VR Shell

The issue here is we are setting the virtual display's size when we
enter WebVR, but not when we exit it to VrShell.  This means that
content is incorrectly sized.

The fix simply sets the virtual display's size when we exit WebVR to VrShell.

BUG= 718578 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2906173002
Cr-Original-Commit-Position: refs/heads/master@{#476074}
Review-Url: https://codereview.chromium.org/2921583003
Cr-Commit-Position: refs/branch-heads/3112@{#108}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/079395cb4a1ae3e6267aada372111300602ceb2e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7b41941ac3c3e7a42d743e5bbae6fe5024edee8

commit f7b41941ac3c3e7a42d743e5bbae6fe5024edee8
Author: billorr <billorr@chromium.org>
Date: Fri Jun 02 04:30:54 2017

Add test for validating the proper size when we exit WebVR to VR browsing.

This is an automated test to validate the fix for crbug/718578.

BUG= 718578 

Review-Url: https://codereview.chromium.org/2918853002
Cr-Commit-Position: refs/heads/master@{#476564}

[modify] https://crrev.com/f7b41941ac3c3e7a42d743e5bbae6fe5024edee8/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/f7b41941ac3c3e7a42d743e5bbae6fe5024edee8/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java

Status: Fixed (was: Started)
Verified in Chrome Canary 61.0.3123.0
Status: Verified (was: Fixed)
Components: Blink>WebXR

Sign in to add a comment