New issue
Advanced search Search tips

Issue 718577 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 618368



Sign in to add a comment

remove AndroidOverlayFactory

Project Member Reported by liber...@chromium.org, May 4 2017

Issue description

AndroidOverlayFactory can be replaced by a callback, since we don't need it.

this will also help us plumb mojo support from the gpu service.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7

commit c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7
Author: liberato <liberato@chromium.org>
Date: Fri May 05 18:59:03 2017

Remove AndroidOverlayFactory

AndroidOverlayFactory is replaced with a callback.  This simplifies it.

Also, it makes plumbing a mojo factory callback from the GPU service
much easier.  The factory type, AndroidOverlayFactoryCB can be compiled
on any platform, to prevent a lot of #ifdef's later.

As part of this, the base::Callback instances are replaced with
RepeatingCallbacks or OnceCallbacks, as appropriate.

BUG= 718577 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2856253004
Cr-Commit-Position: refs/heads/master@{#469742}

[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/base/BUILD.gn
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/base/android/BUILD.gn
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/base/android/android_overlay.cc
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/base/android/android_overlay.h
[delete] https://crrev.com/89b9688d75599341703719d88b5f09841ac4d5de/media/base/android/android_overlay_factory.h
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/base/android/mock_android_overlay.cc
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/base/android/mock_android_overlay.h
[add] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/base/android_overlay_config.cc
[add] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/base/android_overlay_config.h
[add] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/base/android_overlay_mojo_factory.h
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/gpu/BUILD.gn
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/gpu/android_video_decode_accelerator_unittest.cc
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/gpu/android_video_surface_chooser.h
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/gpu/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/gpu/android_video_surface_chooser_impl.h
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/gpu/android_video_surface_chooser_impl_unittest.cc
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/gpu/content_video_view_overlay.cc
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/gpu/content_video_view_overlay.h
[delete] https://crrev.com/89b9688d75599341703719d88b5f09841ac4d5de/media/gpu/content_video_view_overlay_factory.cc
[delete] https://crrev.com/89b9688d75599341703719d88b5f09841ac4d5de/media/gpu/content_video_view_overlay_factory.h
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/mojo/clients/BUILD.gn
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/mojo/clients/mojo_android_overlay.cc
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/mojo/clients/mojo_android_overlay.h
[delete] https://crrev.com/89b9688d75599341703719d88b5f09841ac4d5de/media/mojo/clients/mojo_android_overlay_factory.cc
[delete] https://crrev.com/89b9688d75599341703719d88b5f09841ac4d5de/media/mojo/clients/mojo_android_overlay_factory.h
[modify] https://crrev.com/c9baea5c9d9d2b658d91c48b053ddde9bf9df7b7/media/mojo/clients/mojo_android_overlay_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment