cc property tree nodes should not have owning layer ids. Instead we should use compositor element ids.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3daf2708acac918554319be74a152821bb7feec commit c3daf2708acac918554319be74a152821bb7feec Author: chrishtr <chrishtr@chromium.org> Date: Thu May 11 11:08:02 2017 Change cc::ElementId to be a uint64_t This will: * Make cc::ElementId a fully opaque id to cc (per original design) * Make it easy to use it as a cache key wherever desired * Make all hash lookups involving an element id faster in cc * Simplifies the code I don't think there is any downside, as a uint64_t has 62 bits for node id, which is a large enough number to never be hit in any real web page. TBR=danakj BUG= 718564 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2860293002 Cr-Commit-Position: refs/heads/master@{#470915} [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/cc/animation/animation_player_unittest.cc [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/cc/layers/layer_impl_unittest.cc [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/cc/layers/layer_unittest.cc [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/cc/test/animation_timelines_test_common.cc [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/cc/trees/element_id.cc [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/cc/trees/element_id.h [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/cc/trees/tree_synchronizer_unittest.cc [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/core/dom/DOMNodeIds.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/core/dom/DOMNodeIds.h [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [add] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeStateTest.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/ui/compositor/layer.cc [modify] https://crrev.com/c3daf2708acac918554319be74a152821bb7feec/ui/compositor/layer_animator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f60ca0996ee808f6479a89ea74c665888b41bfd commit 5f60ca0996ee808f6479a89ea74c665888b41bfd Author: chrishtr <chrishtr@chromium.org> Date: Thu May 11 23:09:49 2017 Get rid of two callsites of effect_tree.FindNodeIndexFromOwningLayerId. BUG= 718564 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2876473005 Cr-Commit-Position: refs/heads/master@{#471112} [modify] https://crrev.com/5f60ca0996ee808f6479a89ea74c665888b41bfd/cc/layers/effect_tree_layer_list_iterator_unittest.cc [modify] https://crrev.com/5f60ca0996ee808f6479a89ea74c665888b41bfd/cc/layers/render_surface_impl.cc [modify] https://crrev.com/5f60ca0996ee808f6479a89ea74c665888b41bfd/cc/test/layer_test_common.cc [modify] https://crrev.com/5f60ca0996ee808f6479a89ea74c665888b41bfd/cc/test/layer_test_common.h [modify] https://crrev.com/5f60ca0996ee808f6479a89ea74c665888b41bfd/cc/test/layer_tree_json_parser_unittest.cc [modify] https://crrev.com/5f60ca0996ee808f6479a89ea74c665888b41bfd/cc/trees/damage_tracker_unittest.cc [modify] https://crrev.com/5f60ca0996ee808f6479a89ea74c665888b41bfd/cc/trees/effect_node.h [modify] https://crrev.com/5f60ca0996ee808f6479a89ea74c665888b41bfd/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/5f60ca0996ee808f6479a89ea74c665888b41bfd/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/5f60ca0996ee808f6479a89ea74c665888b41bfd/cc/trees/occlusion_tracker_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f556cef44f474c02e486e7c3e4eec685dc50794c commit f556cef44f474c02e486e7c3e4eec685dc50794c Author: chrishtr <chrishtr@chromium.org> Date: Sat May 13 05:31:01 2017 Fix cc scrollbar layer issues with initialization, and use element ids throughout. 1. Previously, there was an issue with initialization paths for cc scrollbar layers, which may be created when property trees are in an inconsistent state. Now we never try to update property tree opacity during construction, and also pass correct initial opacities from the pending tree rather than assuming 0.0f. 2. Deleted workaround code to bail out during the condition #1 described above. 3. Removed always_use_active_tree_opacity_effect_ids and corresponding methods on layers, in favor of re-using the existing list of scrollbar animation controllers on LayerTreeHostImpl. It turned out that there was an exact match between the layers put in always_use_active_tree_opacity_effect_ids and scrollbars. This also removes another instance of looking up effect id by node. 4. Start always setting ElementId on scrollbar layers, to support #3 above. To do this, added a new namespace for CompsitorElementId, and also performed some related cleanup along the way. BUG= 718564 , 702832 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2877033002 Cr-Commit-Position: refs/heads/master@{#471564} [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/blink/web_scrollbar_layer_impl.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/blink/web_scrollbar_layer_impl.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/input/scrollbar_animation_controller.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/input/scrollbar_animation_controller.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/input/scrollbar_animation_controller_unittest.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/layers/layer.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/layers/layer.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/layers/painted_overlay_scrollbar_layer.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/layers/painted_overlay_scrollbar_layer.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/layers/painted_scrollbar_layer.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/layers/painted_scrollbar_layer.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/layers/scrollbar_layer_impl_base.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/layers/scrollbar_layer_unittest.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/layers/solid_color_scrollbar_layer.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/layers/solid_color_scrollbar_layer.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/trees/layer_tree_impl.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/trees/layer_tree_impl.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/trees/property_tree.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/trees/property_tree.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/cc/trees/property_tree_builder.cc [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/core/animation/AnimationTest.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/web/LinkHighlightImpl.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp [modify] https://crrev.com/f556cef44f474c02e486e7c3e4eec685dc50794c/third_party/WebKit/public/platform/WebScrollbarLayer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1713618a7ed0036cb64f87a096a94f43a6a8761e commit 1713618a7ed0036cb64f87a096a94f43a6a8761e Author: chrishtr <chrishtr@chromium.org> Date: Thu May 18 15:46:41 2017 Stop retrieving scrolling element id from the CompositorElementId. Instead, store it locally. This is possible because ScrollState is the only way to set current_native_scrolling_element on cc::ScrollStateData. Furthermore, ScrollState is a garbage-collected, script-observable class, so referencing Element from it is safe. Also note that ScrollState is part of an unlaunched feature. BUG= 718564 Review-Url: https://codereview.chromium.org/2881423004 Cr-Commit-Position: refs/heads/master@{#472826} [modify] https://crrev.com/1713618a7ed0036cb64f87a096a94f43a6a8761e/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp [modify] https://crrev.com/1713618a7ed0036cb64f87a096a94f43a6a8761e/third_party/WebKit/Source/core/page/scrolling/ScrollState.h [modify] https://crrev.com/1713618a7ed0036cb64f87a096a94f43a6a8761e/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [modify] https://crrev.com/1713618a7ed0036cb64f87a096a94f43a6a8761e/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [modify] https://crrev.com/1713618a7ed0036cb64f87a096a94f43a6a8761e/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18fc5e473594ff6bb062183835a60257def9a627 commit 18fc5e473594ff6bb062183835a60257def9a627 Author: chrishtr <chrishtr@chromium.org> Date: Fri May 19 04:20:59 2017 [SPv1] Always set a CompositorElementId on main graphics layers; use PaintLayer id. This means we will always have an element id in cc property trees, which means we can rely on it as a key for node lookup instead of layer id. BUG= 718564 , 723099 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2890953002 Cr-Commit-Position: refs/heads/master@{#473085} [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/core/animation/AnimationTest.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/core/paint/PaintLayer.h [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.h [modify] https://crrev.com/18fc5e473594ff6bb062183835a60257def9a627/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20 commit 9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20 Author: Chris Harrelson <chrishtr@chromium.org> Date: Fri Jun 02 15:57:50 2017 Replace cc::EffectNode::owning_layer_id with a 64-bit stable_id. This id is an opaque id that should be used only for stability across frames. It is now 64 bits for compatibility with using cc::ElementIds for the opaque id. In SPv1 mode, the Layer id is still the actual value of opaque_id. In SPv2 mode, it will be (but not yet as of this CL) ElementId. Bug: 718564 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6e539536620b6077f6394a81146639b2ac5ed626 Reviewed-on: https://chromium-review.googlesource.com/521755 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: enne <enne@chromium.org> Commit-Queue: Chris harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#476677} [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/ipc/cc_param_traits.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/ipc/cc_param_traits_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/ipc/quads.mojom [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/ipc/render_pass.mojom [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/ipc/render_pass_struct_traits.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/ipc/struct_traits_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/layers/render_surface_impl.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/layers/render_surface_impl.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/layers/render_surface_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/output/ca_layer_overlay.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/output/ca_layer_overlay.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/output/direct_renderer.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/output/direct_renderer.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/output/overlay_processor.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/output/overlay_processor.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/output/overlay_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/quads/draw_quad_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/quads/render_pass.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/quads/render_pass.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/quads/render_pass_draw_quad.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/quads/render_pass_draw_quad.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/quads/render_pass_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/surfaces/display_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/surfaces/surface.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/surfaces/surface.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/surfaces/surface_aggregator.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/surfaces/surface_aggregator.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/surfaces/surface_aggregator_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/surfaces/surface_hittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/surfaces/surface_hittest.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/surfaces/surface_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/test/render_pass_test_utils.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/test/render_pass_test_utils.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/test/surface_aggregator_test_helpers.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/test/surface_aggregator_test_helpers.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/trees/damage_tracker.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/trees/damage_tracker.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/trees/effect_node.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/trees/effect_node.h [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/trees/layer_tree_host_unittest_copyrequest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/trees/property_tree.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/cc/trees/property_tree_builder.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/services/ui/ws/frame_generator_unittest.cc [modify] https://crrev.com/9bdbcce6c4e83bbbc7c52ef37f939b6c76602b20/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74f0e4ce7f608f95e041612c0a2b254023060570 commit 74f0e4ce7f608f95e041612c0a2b254023060570 Author: Chris Harrelson <chrishtr@chromium.org> Date: Tue Jun 06 03:30:26 2017 Use cc::ElementIds as stable ids for effects in SPv2. To do this, fixes the following issues: - Masks accidentally did not already have a property cc::ElementId set. - SVG non-root objects never have a PaintLayer, yet can induce paint properties, so moved the unique id from PaintLayer to PaintRareData. - Stop caching CompositorElementId on ObjectPaintProperties. Now constructing it is fast enough to not need to store it off anywhere. - A single element can have multiple property tree nodes of the same type. For example, a element may simultaneously have a filter, mask and blend-mode/opacity. Bug: 718564 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ife2df0d045a3a5ab2ac9f4f953c991a74980cc61 Reviewed-on: https://chromium-review.googlesource.com/522924 Commit-Queue: Chris harrelson <chrishtr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#477178} [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/animation/AnimationTest.cpp [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/paint/PaintLayer.h [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/paint/RarePaintData.cpp [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/core/paint/RarePaintData.h [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp [modify] https://crrev.com/74f0e4ce7f608f95e041612c0a2b254023060570/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8588f634d6722cf9dc6a48ddc201d8121c2c57f2 commit 8588f634d6722cf9dc6a48ddc201d8121c2c57f2 Author: Kinuko Yasuda <kinuko@chromium.org> Date: Tue Jun 06 13:50:15 2017 Revert "Use cc::ElementIds as stable ids for effects in SPv2." This reverts commit 74f0e4ce7f608f95e041612c0a2b254023060570. Reason for revert: speculative revert for css3/blending/svg-blend-multiply-alpha.html breakage on multiple bots (will re-revert if this didn't fix it) Original change's description: > Use cc::ElementIds as stable ids for effects in SPv2. > > To do this, fixes the following issues: > > - Masks accidentally did not already have a property cc::ElementId set. > - SVG non-root objects never have a PaintLayer, yet can induce paint properties, > so moved the unique id from PaintLayer to PaintRareData. > - Stop caching CompositorElementId on ObjectPaintProperties. Now constructing > it is fast enough to not need to store it off anywhere. > - A single element can have multiple property tree nodes of the same type. For > example, a element may simultaneously have a filter, mask and blend-mode/opacity. > > Bug: 718564 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ife2df0d045a3a5ab2ac9f4f953c991a74980cc61 > Reviewed-on: https://chromium-review.googlesource.com/522924 > Commit-Queue: Chris harrelson <chrishtr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#477178} TBR=pdr@chromium.org,chrishtr@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 718564 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7080613eaaf574087dfeaf26cc925d03417bd819 Reviewed-on: https://chromium-review.googlesource.com/525196 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#477274} [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/animation/AnimationTest.cpp [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/paint/PaintLayer.h [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/paint/RarePaintData.cpp [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/core/paint/RarePaintData.h [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp [modify] https://crrev.com/8588f634d6722cf9dc6a48ddc201d8121c2c57f2/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8590f0ca31af22abdd085ab018dbd8b1543cb4b8 commit 8590f0ca31af22abdd085ab018dbd8b1543cb4b8 Author: Chris harrelson <chrishtr@chromium.org> Date: Tue Jun 06 17:50:40 2017 Revert "Revert "Use cc::ElementIds as stable ids for effects in SPv2."" This reverts commit 8588f634d6722cf9dc6a48ddc201d8121c2c57f2. Reason for revert: css3/blending/svg-blend-multiply-alpha.html is still failing even with this revert: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&showExpectations=true&tests=svg-blend-multiply-alpha Original change's description: > Revert "Use cc::ElementIds as stable ids for effects in SPv2." > > This reverts commit 74f0e4ce7f608f95e041612c0a2b254023060570. > > Reason for revert: speculative revert for css3/blending/svg-blend-multiply-alpha.html breakage on multiple bots (will re-revert if this didn't fix it) > > Original change's description: > > Use cc::ElementIds as stable ids for effects in SPv2. > > > > To do this, fixes the following issues: > > > > - Masks accidentally did not already have a property cc::ElementId set. > > - SVG non-root objects never have a PaintLayer, yet can induce paint properties, > > so moved the unique id from PaintLayer to PaintRareData. > > - Stop caching CompositorElementId on ObjectPaintProperties. Now constructing > > it is fast enough to not need to store it off anywhere. > > - A single element can have multiple property tree nodes of the same type. For > > example, a element may simultaneously have a filter, mask and blend-mode/opacity. > > > > Bug: 718564 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: Ife2df0d045a3a5ab2ac9f4f953c991a74980cc61 > > Reviewed-on: https://chromium-review.googlesource.com/522924 > > Commit-Queue: Chris harrelson <chrishtr@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#477178} > > TBR=pdr@chromium.org,chrishtr@chromium.org > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 718564 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: I7080613eaaf574087dfeaf26cc925d03417bd819 > Reviewed-on: https://chromium-review.googlesource.com/525196 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#477274} TBR=kinuko@chromium.org,ericwilligers@chromium.org,alexis.menard@intel.com,pdr@chromium.org,dongseong.hwang@intel.com,blundell@chromium.org,cabanier@adobe.com,dschulze@chromium.org,rob.buis@samsung.com,chrishtr@chromium.org,junov@chromium.org,rjwright@chromium.org,shans@chromium.org,chromium-reviews@chromium.org,schenney@chromium.org,blundell@google.com No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 718564 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib2461920cb4fbb7e378597f6ceadfc25a3e4e68a Reviewed-on: https://chromium-review.googlesource.com/525935 Reviewed-by: Chris harrelson <chrishtr@chromium.org> Commit-Queue: Chris harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#477334} [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/animation/AnimationTest.cpp [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/paint/PaintLayer.h [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/paint/RarePaintData.cpp [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/core/paint/RarePaintData.h [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp [modify] https://crrev.com/8590f0ca31af22abdd085ab018dbd8b1543cb4b8/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84670c9d1778d069499d138b364dac521c5e389c commit 84670c9d1778d069499d138b364dac521c5e389c Author: Chris Harrelson <chrishtr@chromium.org> Date: Tue Jun 06 20:36:35 2017 Remove mapping from layer id to effect node. Instead change remaining callsites to use effect_tree_index(). In all cases changed, the effect node "owned" by that layer is guaranteed to exist. Enumerated use cases: 1. Scrollbars. These always have effect nodes for opacity, which is enforced by the scrollbar's layer's OpacityCanAnimateOnImplThread() always returning true if it actually animates, which forces an effect node in c::PropertyTreeBuilder. 2. Composited animations on the impl thread. Similary to #1, HasPotentiallyRunningOpacityAnimation will be true for all such cases where Opacity is actually mutated. 3. cc::Layer::SetOpacity (main-thread): the code in Layer::SetOpacity already has logic to force a property tree rebuild if necessary to allocate the effect node, and mutate it if no rebuild is necessary. Bug: 718564 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2519a18428d9274ca1345e540e496643a4faf601 Reviewed-on: https://chromium-review.googlesource.com/522930 Commit-Queue: Chris harrelson <chrishtr@chromium.org> Reviewed-by: Walter Korman <wkorman@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#477392} [modify] https://crrev.com/84670c9d1778d069499d138b364dac521c5e389c/cc/layers/layer.cc [modify] https://crrev.com/84670c9d1778d069499d138b364dac521c5e389c/cc/layers/layer_impl.cc [modify] https://crrev.com/84670c9d1778d069499d138b364dac521c5e389c/cc/trees/layer_tree_host.cc [modify] https://crrev.com/84670c9d1778d069499d138b364dac521c5e389c/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/84670c9d1778d069499d138b364dac521c5e389c/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/84670c9d1778d069499d138b364dac521c5e389c/cc/trees/property_tree.cc [modify] https://crrev.com/84670c9d1778d069499d138b364dac521c5e389c/cc/trees/property_tree.h [modify] https://crrev.com/84670c9d1778d069499d138b364dac521c5e389c/cc/trees/property_tree_builder.cc [modify] https://crrev.com/84670c9d1778d069499d138b364dac521c5e389c/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfd95a106eaaf3a5e6712f8f21e9979dfda4aa16 commit dfd95a106eaaf3a5e6712f8f21e9979dfda4aa16 Author: Chris Harrelson <chrishtr@chromium.org> Date: Tue Jun 13 20:01:48 2017 Remove all callsites to FindNodeFromOwningLayerId and FindNodeIndexFromOwningLayerId outside of property tree internals. Bug: 718564 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I85a35132e855c08b6f4cfac168887350ae82b5d1 Reviewed-on: https://chromium-review.googlesource.com/532194 Commit-Queue: Chris harrelson <chrishtr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#479113} [modify] https://crrev.com/dfd95a106eaaf3a5e6712f8f21e9979dfda4aa16/cc/layers/layer_impl.cc [modify] https://crrev.com/dfd95a106eaaf3a5e6712f8f21e9979dfda4aa16/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/dfd95a106eaaf3a5e6712f8f21e9979dfda4aa16/cc/trees/property_tree.h [modify] https://crrev.com/dfd95a106eaaf3a5e6712f8f21e9979dfda4aa16/cc/trees/property_tree_builder.cc [modify] https://crrev.com/dfd95a106eaaf3a5e6712f8f21e9979dfda4aa16/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f075b29e4fde077ed31ebe11c40077fd70a5972 commit 0f075b29e4fde077ed31ebe11c40077fd70a5972 Author: Chris Harrelson <chrishtr@chromium.org> Date: Thu Jun 15 02:49:56 2017 Remove mapping from layer ids to property tree node ids. Bug: 718564 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idda61c671b76d7da06c23ea1ca679ee9e914bc70 Reviewed-on: https://chromium-review.googlesource.com/534574 Commit-Queue: Chris harrelson <chrishtr@chromium.org> Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#479585} [modify] https://crrev.com/0f075b29e4fde077ed31ebe11c40077fd70a5972/cc/layers/layer.cc [modify] https://crrev.com/0f075b29e4fde077ed31ebe11c40077fd70a5972/cc/layers/layer.h [modify] https://crrev.com/0f075b29e4fde077ed31ebe11c40077fd70a5972/cc/layers/layer_impl.cc [modify] https://crrev.com/0f075b29e4fde077ed31ebe11c40077fd70a5972/cc/layers/layer_impl_test_properties.cc [modify] https://crrev.com/0f075b29e4fde077ed31ebe11c40077fd70a5972/cc/trees/layer_tree_host.cc [modify] https://crrev.com/0f075b29e4fde077ed31ebe11c40077fd70a5972/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/0f075b29e4fde077ed31ebe11c40077fd70a5972/cc/trees/property_tree.cc [modify] https://crrev.com/0f075b29e4fde077ed31ebe11c40077fd70a5972/cc/trees/property_tree.h [modify] https://crrev.com/0f075b29e4fde077ed31ebe11c40077fd70a5972/cc/trees/property_tree_builder.cc [modify] https://crrev.com/0f075b29e4fde077ed31ebe11c40077fd70a5972/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00b72cb11b80f37c7c51acf6a6820b0774f3abac commit 00b72cb11b80f37c7c51acf6a6820b0774f3abac Author: Chris Harrelson <chrishtr@chromium.org> Date: Sat Jun 17 01:10:28 2017 Remove owning_layer_id from clip nodes. Bug: 718564 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0d5efd019607fab0a94860ceb868986b369cdb90 Reviewed-on: https://chromium-review.googlesource.com/538926 Reviewed-by: Chris harrelson <chrishtr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#480257} [modify] https://crrev.com/00b72cb11b80f37c7c51acf6a6820b0774f3abac/cc/trees/clip_node.cc [modify] https://crrev.com/00b72cb11b80f37c7c51acf6a6820b0774f3abac/cc/trees/clip_node.h [modify] https://crrev.com/00b72cb11b80f37c7c51acf6a6820b0774f3abac/cc/trees/property_tree_builder.cc [modify] https://crrev.com/00b72cb11b80f37c7c51acf6a6820b0774f3abac/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f8e2395893e878ef27ae38f02deaf5a13250733 commit 7f8e2395893e878ef27ae38f02deaf5a13250733 Author: Chris Harrelson <chrishtr@chromium.org> Date: Sat Jun 17 01:19:29 2017 Remove owning_layer_id from transform nodes in cc. Bug: 718564 , 709137 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I03720b7e354d4e3d6dba621a01d40a941513c961 Reviewed-on: https://chromium-review.googlesource.com/538977 Commit-Queue: Chris harrelson <chrishtr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#480259} [modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/layers/layer_impl.cc [modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/layers/layer_impl.h [modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/layers/layer_utils.cc [modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/trees/property_tree.cc [modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/trees/property_tree_builder.cc [modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/trees/transform_node.cc [modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/trees/transform_node.h [modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp [modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
Comment 1 by bugdroid1@chromium.org
, May 11 2017