Memory instrumentation interfaces should be accessible to all child processes |
||
Issue descriptionThere are a few Mojo interfaces -- memory_instrumentation::mojom::Coordinator and discardable_memory::mojom::DiscardableSharedMemoryManager -- which each child process attempts to acquire from its connection to the browser. Binders for these interfaces are at present only registered by RenderProcessHostImpl, and thus only made available to render processes. We should instead have some common ConnectionFilter installed on all browser-side ServiceManagerConnections which handles these interface requests.
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7a279c0eebd469a2aac1177710cce723f8c060d commit c7a279c0eebd469a2aac1177710cce723f8c060d Author: Ken Rockot <rockot@chromium.org> Date: Fri May 05 04:09:19 2017 Make some browser interfaces accessible to all child processes The discardable shared memory manager and resource_coordinator's memory instrumentation interfaces may be usable by any child process, and memory instrumentation is in fact already in use by GPU and renderers. This moves these interface binders to a shared ConnectionFilter attached to all browser-side ServiceManagerConnection instances, ensuring that all content child processes can bind the interfaces. BUG= 718559 Change-Id: I8a1a1ff5b749365d020f72480e25ba2d88a025b3 Reviewed-on: https://chromium-review.googlesource.com/496607 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Ben Goodger <ben@chromium.org> Cr-Commit-Position: refs/heads/master@{#469593} [modify] https://crrev.com/c7a279c0eebd469a2aac1177710cce723f8c060d/content/browser/BUILD.gn [modify] https://crrev.com/c7a279c0eebd469a2aac1177710cce723f8c060d/content/browser/browser_context.cc [modify] https://crrev.com/c7a279c0eebd469a2aac1177710cce723f8c060d/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/c7a279c0eebd469a2aac1177710cce723f8c060d/content/browser/renderer_host/render_process_host_impl.cc [add] https://crrev.com/c7a279c0eebd469a2aac1177710cce723f8c060d/content/browser/service_manager/common_browser_interfaces.cc [add] https://crrev.com/c7a279c0eebd469a2aac1177710cce723f8c060d/content/browser/service_manager/common_browser_interfaces.h [modify] https://crrev.com/c7a279c0eebd469a2aac1177710cce723f8c060d/content/browser/service_manager/service_manager_context.cc
,
May 5 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by roc...@chromium.org
, May 4 2017