New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 718556 link

Starred by 6 users
Status: Fixed
Owner:
elawrence@chromium.org
Closed: Jun 2017
Cc:
█ forg@chromium.org
maxwalker@chromium.org
est...@chromium.org
█ ainslie@chromium.org
pkasting@chromium.org
parisa@chromium.org
█ f...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Feature
Team-Security-UX

Blocking:
issue 721898



Sign in to add a comment

HTTPBad Phase 2: Show 'Not Secure' for non-secure pages while Incognito

Project Member Reported by elawrence@chromium.org, May 4 2017 
Visit http://example.com while Incognito
Expect: "Not secure" warning in Security Chip as outlined in this blog post: https://security.googleblog.com/2017/04/next-steps-toward-more-connection.html

Comment 1 by elawrence@chromium.org, May 10 2017

Labels: OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows

Comment 2 by elawrence@chromium.org, May 12 2017

Labels: -Type-Bug Type-Feature

Comment 3 by elawrence@chromium.org, May 12 2017

Blocking: 721898

Comment 4 by est...@chromium.org, Jun 7 2017

Cc: ainslie@chromium.org maxwalker@chromium.org forg@chromium.org parisa@chromium.org f...@chromium.org pkasting@chromium.org est...@chromium.org
 Issue 585671  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb56996bdeb8a961f734140764e6c8e2218b7b21

commit bb56996bdeb8a961f734140764e6c8e2218b7b21
Author: elawrence <elawrence@chromium.org>
Date: Wed Jun 14 20:42:50 2017

Implement 'Not secure' warning for non-secure pages in Incognito mode

Non-secure HTTP cannot meet users’ security and privacy expectations
when browsing the web. This change marks HTTP pages as 'Not secure' in
the Security Chip UI when the user is browsing in Incognito mode.

BUG= 718556 
TESTS=
browser_tests.exe --gtest_filter=SecurityStateTabHelperIncognitoTest.*
browser_tests.exe --gtest_filter=SecurityStateTabHelperTest.PasswordSecurityLevelDowngraded
browser_tests.exe --gtest_filter=SecurityStateTabHelperTest.SecurityLevelNotDowngradedForHTTPInGuestMode
components_unittests.exe --gtest_filter=SecurityStateTest.IncognitoFlagPropagates
components_unittests.exe --gtest_filter=SecurityStateTest.MarkHttpAsStatusHistogram
components_unittests.exe --gtest_filter=SecurityStateContentUtilsTest.HTTPWarning

Review-Url: https://codereview.chromium.org/2917873004
Cr-Commit-Position: refs/heads/master@{#479494}

[modify] https://crrev.com/bb56996bdeb8a961f734140764e6c8e2218b7b21/chrome/browser/ssl/security_state_tab_helper.cc
[modify] https://crrev.com/bb56996bdeb8a961f734140764e6c8e2218b7b21/chrome/browser/ssl/security_state_tab_helper.h
[modify] https://crrev.com/bb56996bdeb8a961f734140764e6c8e2218b7b21/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc
[modify] https://crrev.com/bb56996bdeb8a961f734140764e6c8e2218b7b21/components/security_state/content/content_utils.cc
[modify] https://crrev.com/bb56996bdeb8a961f734140764e6c8e2218b7b21/components/security_state/content/content_utils_unittest.cc
[modify] https://crrev.com/bb56996bdeb8a961f734140764e6c8e2218b7b21/components/security_state/core/security_state.cc
[modify] https://crrev.com/bb56996bdeb8a961f734140764e6c8e2218b7b21/components/security_state/core/security_state.h
[modify] https://crrev.com/bb56996bdeb8a961f734140764e6c8e2218b7b21/components/security_state/core/security_state_unittest.cc
[modify] https://crrev.com/bb56996bdeb8a961f734140764e6c8e2218b7b21/components/security_state_strings.grdp
[modify] https://crrev.com/bb56996bdeb8a961f734140764e6c8e2218b7b21/ios/chrome/browser/ssl/ios_security_state_tab_helper.mm

Comment 7 by elawrence@chromium.org, Jun 14 2017

Status: Fixed (was: Started)
►

Sign in to add a comment