Current target is M61.

The NextAction date has arrived: 2017-05-26

> The NextAction date has arrived: 2017-05-26

60 has branched!

Raymes, Ben: what's the latest on MD site details?

Hmm ... obviously Site Details won't make M60. Implementation is still early, and we don't have final mocks. At this stage I'm hopeful it will make M61. Patti has been splitting her time between projects but should be focused 100% on Site Details going forward.

M61 feature freeze just passed and, uh... is about to pass again.
What's the status of Site Details?

The primary work here is to remove the Flag from chrome://flags and change the code to show the link/button unconditionally.

Reassigning to Patti as part of the PageInfo harmony / removing non-default settings work.

emilyschechter@: Do we need to consult UI, or are we ready for this?

Patti is taking care of this as part of the Harmony changes. The plan of action is here: https://groups.google.com/a/google.com/d/msg/chrome-ui-review/pLSR5R2f3YA/Yum7RdctAgAJ

So I guess that counts as "ready"? :-)

Well, Patti is tweaking the UI to look like the mocks (you can see in the mocks it looks slightly different than in the current state)

Started this at https://chromium-review.googlesource.com/c/chromium/src/+/686093, and related, reordering Certificate/Cookies at https://chromium-review.googlesource.com/c/chromium/src/+/686199/

A note that the latter patch changes up some of the padding in Page Info - see attached screenshots for reference. A summary of the padding changes as of patchset #5 (affecting Views only, Mac padding remains the same):
 - The top padding for the Certificate link is now 3 dp less than it was after the former patch (686093).
 - The top padding for the Site settings link is now 3 dp less than it used to be.
 - The bottom padding for the Site settings link is 4dp less than it used to be.

The rationale for this was because the previous padding logic seemed to be pretty arbitrary, and hopefully the new code is a bit clearer, but will wait on feedback from reviewers (lgarron) and UI folks before going ahead with this.

Deleted: reorder-none.png 16.5 KB

	reorder-none.png 16.5 KB View Download

Deleted: reorder-some.png 21.4 KB

	reorder-some.png 21.4 KB View Download

Deleted: reorder-boundsdrawn.png 24.3 KB

	reorder-boundsdrawn.png 24.3 KB View Download

Forgot to attach this as well - this is the current state of Page Info with --show-cert-link enabled & bounds drawn.

Deleted: original-boundsdrawn.png 25.4 KB

	original-boundsdrawn.png 25.4 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6

commit 72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6
Author: Patti <patricialor@chromium.org>
Date: Fri Sep 29 04:51:52 2017

Desktop Page Info: Turn on --show-cert-link by default and delete the switch.

Since r503089 removed factory-default settings from the Page Info, there is now
room to always show page certificate information. This patch turns on the
--show-cert-link flag, which will do this, by default.

Bug:  718553 
Change-Id: Ic293c720337d5638f6097b481cfa7bc341b6abdf
Reviewed-on: https://chromium-review.googlesource.com/686093
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505295}
[modify] https://crrev.com/72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6/chrome/browser/about_flags.cc
[modify] https://crrev.com/72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6/chrome/browser/ui/page_info/page_info_ui.cc
[modify] https://crrev.com/72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6/chrome/browser/ui/page_info/page_info_ui.h
[modify] https://crrev.com/72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6/chrome/common/chrome_switches.cc
[modify] https://crrev.com/72f1f3a94ca87cf01e54e902f1d4ba0ae7b125c6/chrome/common/chrome_switches.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8c61620a6eacc27446d737130d4ec926db8972a

commit e8c61620a6eacc27446d737130d4ec926db8972a
Author: Patti <patricialor@chromium.org>
Date: Fri Sep 29 07:58:03 2017

Desktop Page Info: Order permissions before cookies/certificate info.

Since permissions are only shown if they're non-factory-default, show them first
(over showing certificate and cookie information, which are always shown).

Bug:  535074 ,  718553 
Change-Id: I842e684d43c1f7655f8952b07e590affcbc36a39
Reviewed-on: https://chromium-review.googlesource.com/686199
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505322}
[modify] https://crrev.com/e8c61620a6eacc27446d737130d4ec926db8972a/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/e8c61620a6eacc27446d737130d4ec926db8972a/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/e8c61620a6eacc27446d737130d4ec926db8972a/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/e8c61620a6eacc27446d737130d4ec926db8972a/chrome/browser/ui/views/page_info/page_info_bubble_view.h

Hi Patricia, is this supposed to happen in Canary 63.0.3230.0?

Deleted: Canary63.0.3230.0_MultipleCookiesEntries.png 53.5 KB

	Canary63.0.3230.0_MultipleCookiesEntries.png 53.5 KB View Download

Um, no :(
On the bright side, someone already filed this at  Issue 770605  and I have a fix w/ test running on trybots at https://chromium-review.googlesource.com/c/chromium/src/+/696461 so it will hopefully be fixed soon!

Thanks so much for the other bug reference and fixing it!

Reopening because the tooltip on the certificate link is not a11y-compliant - I'm working on this now.

Can you elaborate on what specifically was non-compliant?

Sorry - the tooltip says "Issued by <Certificate Authority>" for valid certificates, but tooltips are supposed to be used for a11y. The mocks say the tooltip should be "Show certificate" instead (regardless of certificate validity). I'll ping the mocks to you privately.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b2acc1826f4604dffa28470e9f4e2481e6f8162

commit 8b2acc1826f4604dffa28470e9f4e2481e6f8162
Author: Patti <patricialor@chromium.org>
Date: Mon Oct 09 23:51:40 2017

Desktop Page Info: Certificate link tooltip should be used for a11y purposes.

Currently, the tooltip on the Page Info bubble's certificate 'Valid' / 'Invalid'
link will show which Certificate Authority issued the certificate belonging to
the current site. For accessibility purposes, this link should indicate that
clicking on it will open the certificate viewer, so fix this by updating the
tooltip to say so as well as show the certificate issuer.

Bug:  718553 
Change-Id: Icb6e68f1b1ca91c1ddc23357a950069f0703e4c0
Reviewed-on: https://chromium-review.googlesource.com/696724
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507537}
[modify] https://crrev.com/8b2acc1826f4604dffa28470e9f4e2481e6f8162/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/8b2acc1826f4604dffa28470e9f4e2481e6f8162/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/8b2acc1826f4604dffa28470e9f4e2481e6f8162/components/page_info_strings.grdp

 Issue 792338  has been merged into this issue.