[MD settings] site settings not tracking UMA or revocations |
|||||
Issue descriptionin chrome://settings/content/* when adding or removing a site exception, a call to PermissionUtil::ScopedRevocationReporter should be made to track the revocations (to match the behavior of the old options). Ditto for UMA tracking.
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1c163ea6bf56b21576bed89fcf4162eebb2ab91 commit b1c163ea6bf56b21576bed89fcf4162eebb2ab91 Author: dschuyler <dschuyler@chromium.org> Date: Fri May 05 01:15:40 2017 [MD settings] UMA and RevocationReporter in site settings This CL adds UMA and Revocation reporting from site settings when a site exception is added or removed. The goal is to match the behavior of the old options. BUG= 718544 Review-Url: https://codereview.chromium.org/2861793005 Cr-Commit-Position: refs/heads/master@{#469561} [modify] https://crrev.com/b1c163ea6bf56b21576bed89fcf4162eebb2ab91/chrome/browser/ui/webui/settings/site_settings_handler.cc
,
May 5 2017
,
May 5 2017
The bug should be 'fixed' with the CL above. Unit testing for the UMA is in CL https://codereview.chromium.org/2862183002/
,
May 5 2017
Thanks - can you please mark which OS this targets? My guess would be OS-All but can you please confirm?
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/238a3acf12b53686a2b043ef0b296a5bf7d32845 commit 238a3acf12b53686a2b043ef0b296a5bf7d32845 Author: dschuyler <dschuyler@chromium.org> Date: Fri May 05 23:15:18 2017 [MD settings] test UMA when changing site settings exceptions This CL adds unit test for the changes in CL 2861793005. BUG= 718544 Review-Url: https://codereview.chromium.org/2862183002 Cr-Commit-Position: refs/heads/master@{#469794} [modify] https://crrev.com/238a3acf12b53686a2b043ef0b296a5bf7d32845/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
,
May 5 2017
To #5, I believe Android and IOS are excluded.
,
May 6 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8e6f13bf85e4ec2783ddc843bd1d7ca09b51ab8 commit f8e6f13bf85e4ec2783ddc843bd1d7ca09b51ab8 Author: Dave Schuyler <dschuyler@chromium.org> Date: Mon May 08 18:21:20 2017 [MD settings] UMA and RevocationReporter in site settings This CL adds UMA and Revocation reporting from site settings when a site exception is added or removed. The goal is to match the behavior of the old options. BUG= 718544 Review-Url: https://codereview.chromium.org/2861793005 Cr-Commit-Position: refs/heads/master@{#469561} (cherry picked from commit b1c163ea6bf56b21576bed89fcf4162eebb2ab91) Review-Url: https://codereview.chromium.org/2872693002 . Cr-Commit-Position: refs/branch-heads/3071@{#452} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/f8e6f13bf85e4ec2783ddc843bd1d7ca09b51ab8/chrome/browser/ui/webui/settings/site_settings_handler.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dschuyler@chromium.org
, May 4 2017