Set up a unified build overlay for reef |
|||
Issue descriptionWe cannot reuse the same overlay with a USE=unibuild flag because: - I'm not sure how to get the buildbot to provide that flag - The output build metadata would overwrite with the normal reef metadata Therefore it seems best to create a new private overlay for the reef unified build. This will involve some duplication, I suspect. This bug tracks that effort.
,
May 4 2017
I believe that cbuildbot configs can specify USE flags, but we do need a unique board name.
,
May 5 2017
Don, I'm a bit worried about creating a new overlay and keeping it in sync with the existing one. Do you think we could look at the unibuild flag in the metadata and put the artifacts in reef-uni automatically in the buildbot? That would avoid creating a new private overlay.
,
May 5 2017
The USE flag is easy, renaming the board on the fly is nearly impossible (would be a lot easier if some messy code was refactored, but still hard). I'm NOT an expert on overlays, but I thought it was possible to have the new one inherit from another, meaning reef-uni = reef + use flag. Is that not true? Isn't that what we did for things like the freon transition where we had multiple boards for the same hardware before?
,
May 5 2017
Thanks Don, let me dig into that angle a bit.
,
May 12 2017
,
May 12 2017
Mike, please see crbug.com/717702
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3c70d44ffe73f5635da869a17d663e14575b80b1 commit 3c70d44ffe73f5635da869a17d663e14575b80b1 Author: Simon Glass <sjg@chromium.org> Date: Tue May 23 17:24:03 2017 cros-board: Output the reference board with unified builds To provide a unified build for an existing board we create a new overlay called <board>-uni. For example, the unified build for reef is reef-uni. This is not actually a build target for firmware so adjust get_current_board_with_variant() to return the original board (here "reef") in this situation. This allows us to bring in the reef overlay and build firmware without creating a special new target in the various firmware ebuilds. BUG= chromium:718534 TEST=./build_packages --board=reef-uni --nowithautotest --noworkon Change-Id: Ib3848b0cb1dddfa2fef7024d7928d58a67cc9bb2 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/503469 Reviewed-by: Aaron Durbin <adurbin@chromium.org> [modify] https://crrev.com/3c70d44ffe73f5635da869a17d663e14575b80b1/eclass/cros-board.eclass
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5909789b3c72c1e2c18d7db36ac0fa6a044b3f74 commit 5909789b3c72c1e2c18d7db36ac0fa6a044b3f74 Author: Simon Glass <sjg@chromium.org> Date: Tue May 23 17:24:03 2017 cros-board: Add reef-uni This board unifies all boards that use reef as a reference design. It is based on the reef private overlay, but with USE=unibuild enabled. BUG= chromium:718534 TEST=./build_packages --board=reef-uni --nowithautotest --noworkon Change-Id: I7e03cdd18546ebb7a0535a2df47698b2c429fbcc Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/503470 Reviewed-by: Aaron Durbin <adurbin@chromium.org> [modify] https://crrev.com/5909789b3c72c1e2c18d7db36ac0fa6a044b3f74/eclass/cros-board.eclass
,
Jun 1 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sjg@chromium.org
, May 4 2017