New issue
Advanced search Search tips

Issue 718527 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Print To PDF File Dialog Does Not Honor Download Location Setting If It Doesn't Exist

Reported by a...@richman.io, May 4 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce the problem:
1. mkdir /tmp/downloads
2. Configure Settings -> Downloads -> Download location to point at /tmp/downloads
3. rmdir /tmp/downloads
4. Attempt to print any page to PDF.
5. Observe that the dialog opens in /tmp/, not creating /tmp/downloads as any other file download does.

What is the expected behavior?
The print to PDF dialog should create the download location directory if it doesn't already exist, as the standard download dialog does.

What went wrong?
The download location directory does not exist and is not created, so the dialog shows the parent directory instead.

Did this work before? N/A 

Chrome version: 57.0.2987.133  Channel: n/a
OS Version: Arch 4.8.13 x86_64
Flash Version: Shockwave Flash 14.0 r0

Also Save To PDF files don't show up as a downloaded file, which would be nice since currently it's not obvious after clicking OK on the dialog that anything has happened.
 

Comment 1 by ajha@chromium.org, May 10 2017

Labels: Needs-Milestone
Cc: kkaluri@chromium.org
Components: Internals>Printing
Labels: -Needs-Milestone M-61 OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Tested this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.5 with #57.0.2987.133 and also in stable #59.0.3071.86, Canary #61.0.3128.0

These are the steps followed 

1. Create a folder in Desktop -> AA folder
2. Configure Settings -> Downloads -> Download location to point at "AA folder"
3. Remove the AA folder
4. Attempt to print any page to PDF.
5. Observe that the dialog opens in Desktop/, not creating Desktop -> AA 

Observed this behavior from M-54 builds, in less than M-54 builds irrespective download location, while saving the pdf page dialog opens in "Documents" Folder.

Untriaging this issue for further triage from dev team
Attaching the screen-casts for reference.
718527-M_54.mp4
1.5 MB View Download
718527-M_53.mp4
2.7 MB View Download
Owner: rbpotter@chromium.org
Status: Assigned (was: Untriaged)
Will take a look since I merged the downloads/save as PDF locations a while ago.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd822dd88fd5f1af99afb1ac3228e7bdad2ecc81

commit dd822dd88fd5f1af99afb1ac3228e7bdad2ecc81
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Jun 22 22:53:21 2017

Print Preview: Create Save As PDF directory if it does not exist.

If the default Save As PDF directory (which is the same as the user's
default downloads directory) does not exist, create it before opening
the select file dialog. Otherwise, the select file dialog will open in
the lowest level folder on the path that already exists.

BUG= 718527 

Review-Url: https://codereview.chromium.org/2952043002
Cr-Commit-Position: refs/heads/master@{#481699}

[modify] https://crrev.com/dd822dd88fd5f1af99afb1ac3228e7bdad2ecc81/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/dd822dd88fd5f1af99afb1ac3228e7bdad2ecc81/chrome/browser/ui/webui/print_preview/print_preview_handler.h

Status: Fixed (was: Assigned)
Working for me on Canary (61.0.3141.0). Tested on Windows 10.
Labels: TE-Verfied-61.0.3141.0 TE-Verified-M61
Verified this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.5 with chrome #61.0.3141.0. Observed while saving pdf, print preview creating directory if path doesn't exists. hence adding TE-Verified labels

Attaching the screen-cast for reference.
718527.mp4
4.1 MB View Download

Sign in to add a comment