New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 718525 link

Starred by 2 users
Status: Fixed
Owner:
xidac...@chromium.org
Closed: May 2017
Cc:
pdr@chromium.org
█ wkorman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Unify touchaction enums

Project Member Reported by xidac...@chromium.org, May 4 2017 
At this moment, there are three TouchAction enums under:
a. content/common/input/touch_action.h
b. third_party/WebKit/Source/public/web/WebTouchAction.h
c. third_party/WebKit/Source/core/style/ComputedStyleConstants.h

And they are doing the same thing!

We should unify them, and put it under platform/graphics.

Comment 1 by wkorman@chromium.org, May 4 2017 

I think we may need the canonical one to be under cc/animation (or input if you create that dir) rather than platform/graphics, for deps reasons, maybe also so that content/ can reference it, but open to what you find from your exploration.

Comment 2 by xidac...@chromium.org, May 4 2017 

Yes, I agree that the canonical one should be under cc. I saw that cc already have a cc/input/ dir, does it make more sense to put it under cc/input/ then?

Comment 3 by wkorman@chromium.org, May 4 2017 

Yes, under cc/input seems better.
Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa0199e7e18ee33c28356449b6ba48ab41c879e7

commit fa0199e7e18ee33c28356449b6ba48ab41c879e7
Author: xidachen <xidachen@chromium.org>
Date: Thu May 11 11:34:26 2017

Unify TouchAction classes

There are three TouchAction classes in chromium codebase and they look
and function exact the same. This CL unifies them into one. We put a
canonical one under cc/input/, and then the one in blink is placed under
platform/graphics, the one in blink is just using cc's TouchAction. We also
create a WebTouchAction enum under public/platform/ which directly uses the
TouchAction in platform/graphics/. The reason of adding WebTouchAction is that
there are methods in WebWidgetClient.h that is overridden by class under content/.

This CL does pure refactor, it causes no behavior change at all.

BUG= 718525 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2863693003
Cr-Commit-Position: refs/heads/master@{#470919}

[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/cc/BUILD.gn
[add] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/cc/input/touch_action.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/browser/renderer_host/input/input_router_impl.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/browser/renderer_host/input/touch_action_filter.cc
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/browser/renderer_host/input/touch_action_filter.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/browser/renderer_host/input/touch_action_filter_unittest.cc
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/child/assert_matching_enums.cc
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/common/BUILD.gn
[delete] https://crrev.com/02b1d73344512180911bc5280438b840dd5105c8/content/common/input/touch_action.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/common/input_messages.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/renderer/render_view_impl.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/renderer/render_widget.cc
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/content/renderer/render_widget.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/events/TouchEvent.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/events/TouchEvent.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/events/TouchEventTest.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/input/TouchActionUtil.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/input/TouchActionUtil.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/input/TouchEventManager.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/layout/LayoutTheme.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/platform/graphics/TouchAction.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/public/platform/WebTouchAction.h
[delete] https://crrev.com/02b1d73344512180911bc5280438b840dd5105c8/third_party/WebKit/public/web/WebTouchAction.h
[modify] https://crrev.com/fa0199e7e18ee33c28356449b6ba48ab41c879e7/third_party/WebKit/public/web/WebWidgetClient.h

Comment 5 by xidac...@chromium.org, May 11 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment