--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Hey Tommy, just wanted to check whether you'd have a chance to take a look at this. As mentioned in c#0, we basically just want to stop suppressing the row of text when signin is disabled by policy, and replace it with some text describing why there's no way for the user to sign in.

Hey Eli,

I haven't looked at this yet. What's your timeline?

Tommy

Whenever you have time, there's no particular rush :) I'll just mark this as Assigned for now, so we'll be pinged again in a month if we haven't started looking at it by then. Thanks Tommy!

--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Moving back to assigned so we continue to get pings.

--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Hey Tommy, just want to make sure this is still something that you plan to get to eventually. It's hopefully a pretty minimal change. Any thoughts on when you'll be able to pick this small polish bug up?

I do plan to get to it eventually. Do you have a specific date or milestone?

Would M63 be a reasonable target?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de475e3004ed21206713cf3365f8aedceebbf351

commit de475e3004ed21206713cf3365f8aedceebbf351
Author: Tommy C. Li <tommycli@chromium.org>
Date: Thu Aug 17 00:22:59 2017

MD Settings People: Add a Sign-in disabled by administrator policy

Bug:  718520 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3db8987dd0765d47fa691aacd7b976645f9a32fa
Reviewed-on: https://chromium-review.googlesource.com/614059
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495010}
[modify] https://crrev.com/de475e3004ed21206713cf3365f8aedceebbf351/chrome/app/settings_chromium_strings.grdp
[modify] https://crrev.com/de475e3004ed21206713cf3365f8aedceebbf351/chrome/app/settings_google_chrome_strings.grdp
[modify] https://crrev.com/de475e3004ed21206713cf3365f8aedceebbf351/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/de475e3004ed21206713cf3365f8aedceebbf351/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

tommycli@ Could you please help us with the group policy name and steps to verify this issue from TE-End. 

Thank You...

Woot, thanks for landing this Tommy! Could you also include a screenshot of what it looks like?

Re kkaluri: try https://www.chromium.org/administrators/policy-list-3#SigninAllowed

Thanks Tommy!

My only comment is that we probably still don't want to include the "Sign in to Chrome/Chromium" button when it's disabled by policy. In the current implementation, we remove both the button and the descriptive row beneath it. I think we still want to remove the button, and just include the descriptive row beneath it that you have in your screenshot.

Is that possible?

Oh yeah. That button should not be displayed in practice. I just generated that screenshot from the JavaScript console.

I'll allow TE to verify that it looks correct when the Policy is actually set correctly.

Oh okay makes sense, sorry for the confusion. Thanks Tommy!