New issue
Advanced search Search tips

Issue 718519 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

gerrit plugin: show Reland button on submitted changes

Project Member Reported by aga...@chromium.org, May 4 2017

Issue description

The reland button should perform a cherry-pick onto the original target branch, error if the result is empty, or edit the commit message to look like a reland if it is successful.

See  issue gerrit:5456  for context.
 
Blocking: gerrit:5456

Comment 2 by aga...@chromium.org, May 19 2017

Blocking: -gerrit:5456
Not actually blocking the other bug in question here, just expected to be completed before it.

Comment 3 by aga...@chromium.org, May 25 2017

Status: Started (was: Assigned)
This has been started: http://cl/157057256

Comment 4 by aga...@chromium.org, May 31 2017

Status: Fixed (was: Started)
The above CL has been landed and will go live with the next deployment.
What is the expected experience with the reland button? I've had my own change and another dev's where we pressed Reland and nothing seemed to happen on two different reverted changes.
Status: Started (was: Fixed)
It should create a new change, and then reload the page to show that change. Investigating to see if that isn't happening, and if not, why not.
The button shows up but throws an error when clicked:

gr-app.js:2164 TypeError: Cannot read property 'revisions' of undefined
    at CQPlugin.<anonymous> (commitqueue.js:297)
    at HTMLElement.fire (gr-app.js:1545)
    at HTMLElement._handleActionTap (gr-app.js:2364)
    at handler (gr-app.js:1516)
    at HTMLElement.decorated (gr-app.js:1707)
    at HTMLElement.fire (gr-app.js:1545)
    at Object.fire (gr-app.js:1530)
    at Object.forward (gr-app.js:1539)
    at Object.click (gr-app.js:1538)
    at HTMLElement.handleNative (gr-app.js:1526)

Will update when I have a fix.
Fix: cl/158213610
Status: Fixed (was: Started)
Above CL has landed. Marking fixed. Will Verify when rolled out.
Status: Started (was: Fixed)
Nvm, leaving open to remain in queue for verification.
Status: Fixed (was: Started)
Button is deployed and working in Canary.

Sign in to add a comment