gerrit plugin: show Reland button on submitted changes |
|||||||
Issue descriptionThe reland button should perform a cherry-pick onto the original target branch, error if the result is empty, or edit the commit message to look like a reland if it is successful. See issue gerrit:5456 for context.
,
May 19 2017
Not actually blocking the other bug in question here, just expected to be completed before it.
,
May 25 2017
,
May 31 2017
The above CL has been landed and will go live with the next deployment.
,
Jun 6 2017
What is the expected experience with the reland button? I've had my own change and another dev's where we pressed Reland and nothing seemed to happen on two different reverted changes.
,
Jun 6 2017
It should create a new change, and then reload the page to show that change. Investigating to see if that isn't happening, and if not, why not.
,
Jun 7 2017
The button shows up but throws an error when clicked:
gr-app.js:2164 TypeError: Cannot read property 'revisions' of undefined
at CQPlugin.<anonymous> (commitqueue.js:297)
at HTMLElement.fire (gr-app.js:1545)
at HTMLElement._handleActionTap (gr-app.js:2364)
at handler (gr-app.js:1516)
at HTMLElement.decorated (gr-app.js:1707)
at HTMLElement.fire (gr-app.js:1545)
at Object.fire (gr-app.js:1530)
at Object.forward (gr-app.js:1539)
at Object.click (gr-app.js:1538)
at HTMLElement.handleNative (gr-app.js:1526)
Will update when I have a fix.
,
Jun 7 2017
Fix: cl/158213610
,
Jun 7 2017
Above CL has landed. Marking fixed. Will Verify when rolled out.
,
Jun 7 2017
Nvm, leaving open to remain in queue for verification.
,
Jun 12 2017
Button is deployed and working in Canary. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by aga...@chromium.org
, May 4 2017