New issue
Advanced search Search tips

Issue 718501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

WebVR: segfault when receiving null image from the rendering context.

Project Member Reported by mthiesse@chromium.org, May 4 2017

Issue description

We crash in VrDisplay when receiving a null image from the rendering context during submitFrame().

Was seeing this on https://with.in/watch/under-neon-lights/ which doesn't currently work on M59+ until  issue 710863  is fixed.
 
Labels: OS-All
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1215009f69ac267d13b072cc2d4c9cda7155fee

commit a1215009f69ac267d13b072cc2d4c9cda7155fee
Author: mthiesse <mthiesse@chromium.org>
Date: Thu May 04 23:29:22 2017

WebVR: Don't crash when receiving null image from rendering context.

Not sure why/how this happens, but I was seeing this infrequently on  https://with.in/watch/under-neon-lights/

BUG= 718501 

Review-Url: https://codereview.chromium.org/2862883002
Cr-Commit-Position: refs/heads/master@{#469517}

[modify] https://crrev.com/a1215009f69ac267d13b072cc2d4c9cda7155fee/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Labels: Merge-Request-59
Project Member

Comment 4 by sheriffbot@chromium.org, May 5 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 8 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ce7c2c63299607f9f56302e7a12c4be34a0fa32

commit 2ce7c2c63299607f9f56302e7a12c4be34a0fa32
Author: Michael Thiessen <mthiesse@google.com>
Date: Mon May 08 15:08:27 2017

WebVR: Don't crash when receiving null image from rendering context.

Not sure why/how this happens, but I was seeing this infrequently on  https://with.in/watch/under-neon-lights/

BUG= 718501 

Review-Url: https://codereview.chromium.org/2862883002
Cr-Commit-Position: refs/heads/master@{#469517}
(cherry picked from commit a1215009f69ac267d13b072cc2d4c9cda7155fee)

Review-Url: https://codereview.chromium.org/2870553003 .
Cr-Commit-Position: refs/branch-heads/3071@{#446}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/2ce7c2c63299607f9f56302e7a12c4be34a0fa32/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Status: Fixed (was: Started)

Comment 7 by j...@with.in, May 8 2017

That looks like a tricky one. Thanks for the fix guys!
Components: Blink>WebXR

Sign in to add a comment