Change TestShellDelegate to make its test pref_service injectable |
||||
Issue descriptionWhile working on this CL: https://codereview.chromium.org/2857103007/ I failed a lot of ash tests because I was trying to read unregistered prefs from the test pref service. Registering the various profile prefs happen in Chrome in browser_prefs.cc [https://cs.chromium.org/chromium/src/chrome/browser/prefs/browser_prefs.cc?q=browser_prefs.cc+package:%5Echromium$&l=467]. Of course this doesn't happen in ash. It seems that the best approach is to let those tests interested in testing features related to the prefs_services inject their own into TestShellDelegate and register in it whatever prefs they want.
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7093bce085613efd785b72f2a66ee8be27f7d6ed commit 7093bce085613efd785b72f2a66ee8be27f7d6ed Author: afakhry <afakhry@chromium.org> Date: Thu May 04 18:22:24 2017 Make the pref_service in TestShellDelegate injectable. This lets tests interested in testing features related to the prefs_services inject their own into TestShellDelegate and register in it whatever prefs they want. BUG= 718472 Review-Url: https://codereview.chromium.org/2861873004 Cr-Commit-Position: refs/heads/master@{#469387} [modify] https://crrev.com/7093bce085613efd785b72f2a66ee8be27f7d6ed/ash/test/test_shell_delegate.cc [modify] https://crrev.com/7093bce085613efd785b72f2a66ee8be27f7d6ed/ash/test/test_shell_delegate.h
,
May 4 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by afakhry@chromium.org
, May 4 2017