InputDeviceManager being set twice |
|||||||
Issue descriptionWhen running mash_browser_tests there are often failures of a Check in ui::InputDeviceManager::SetInstance Two different sources are trying to set themselves as the input device manager: DeviceDataManager [1] InputDeviceManager [2] I'm not sure which is the correct one to use [1] #2 0x7f3eb86b5ccd ui::InputDeviceManager::SetInstance() #3 0x7f3eb86a7a39 ui::DeviceDataManager::DeviceDataManager() #4 0x7f3eab960245 ui::DeviceDataManagerX11::DeviceDataManagerX11() #5 0x7f3eab9601d4 ui::DeviceDataManagerX11::CreateInstance() #6 0x7f3eac467bd5 ui::X11EventSource::X11EventSource() #7 0x7f3eac475e4b ui::X11EventSourceLibevent::X11EventSourceLibevent() #8 0x7f3eb870c1cf _ZN4base10MakeUniqueIN2ui22X11EventSourceLibeventEJRP9_XDisplayEEENS_8internal16MakeUniqueResultIT_E6ScalarEDpOT0_ #9 0x7f3eb870a69b ui::(anonymous namespace)::OzonePlatformX11::CreatePlatformEventSource() #10 0x7f3eb870a488 ui::(anonymous namespace)::OzonePlatformX11::InitializeUI() #11 0x7f3eb86ed208 ui::OzonePlatform::InitializeForUI() #12 0x7f3eb86ed1ba ui::OzonePlatform::InitializeForUI() #13 0x7f3ebc61935c aura::Env::Init() #14 0x7f3ebc6192da aura::Env::CreateInstance() #15 0x7f3ebf7126d7 content::BrowserMainLoop::InitializeToolkit() #16 0x7f3ebf71b8ae content::BrowserMainRunnerImpl::Initialize() #17 0x7f3ebf709dbf content::BrowserMain() #18 0x7f3ec0e9cb16 content::RunNamedProcessTypeMain() #19 0x7f3ec0e9ebff content::ContentMainRunnerImpl::Run() #20 0x7f3ec0e9b82a content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #21 0x7f3eb163ea27 service_manager::Main() #22 0x7f3ec0e9c63b content::ContentMain() #23 0x000004e86fef content::BrowserTestBase::SetUp() #24 0x000003d73fac InProcessBrowserTest::SetUp() #25 0x0000008592ae _ZN7testing8internal12InvokeHelperIRKNSt7__debug6vectorIPN12user_manager4UserESaIS6_EEESt5tupleIJEEE12InvokeMethodIN8chromeos15MockUserManagerEMSG_KFSA_vEEESA_PT_T0_RKSC_ #26 0x000005039b52 testing::internal::HandleExceptionsInMethodIfSupported<>() #27 0x00000502ee54 testing::Test::Run() #28 0x00000502f5dd testing::TestInfo::Run() #29 0x00000502fb7f testing::TestCase::Run() #30 0x000005034eec testing::internal::UnitTestImpl::RunAllTests() #31 0x00000504918e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #32 0x00000503b142 testing::internal::HandleExceptionsInMethodIfSupported<>() #33 0x000005034b8f testing::UnitTest::Run() #34 0x000003d8f911 RUN_ALL_TESTS() #35 0x000003d8e692 base::TestSuite::Run() #36 0x000003d232b2 ChromeTestSuiteRunner::RunTestSuite() #37 0x000003d23399 ChromeTestLauncherDelegate::RunTestSuite() #38 0x000004f14d82 content::LaunchTests() #39 0x000003d23669 LaunchChromeTests() #40 0x000003d1c6e4 main #41 0x7f3ead8c3f45 __libc_start_main #42 0x000000839854 <unknown> [2] #3 0x00000357262c ui::InputDeviceClient::InputDeviceClient() #4 0x0000035724ca ui::InputDeviceClient::InputDeviceClient() #5 0x00000352898e _ZN4base10MakeUniqueIN2ui17InputDeviceClientEJEEENS_8internal16MakeUniqueResultIT_E6ScalarEDpOT0_ #6 0x000007940ff8 ChromeBrowserMainExtraPartsViews::ServiceManagerConnectionStarted() #7 0x000003e0350f ChromeBrowserMainParts::ServiceManagerConnectionStarted() #8 0x7f3ebf712097 content::BrowserMainLoop::InitializeMojo() #9 0x7f3ebf70e7bb content::BrowserMainLoop::BrowserThreadsStarted() #10 0x7f3ebe9fb7a5 _ZN4base8internal13FunctorTraitsIMN7content13URLLoaderImplEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_ #11 0x7f3ebf718841 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_ #12 0x7f3ebf7187e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #13 0x7f3ebf71872c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #14 0x7f3ebe9d401d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv #15 0x7f3ec025bc7b content::StartupTaskRunner::RunAllTasksNow() #16 0x7f3ebf70d6d0 content::BrowserMainLoop::CreateStartupTasks() #17 0x7f3ebf71ba77 content::BrowserMainRunnerImpl::Initialize() #18 0x7f3ebf709dbf content::BrowserMain() #19 0x7f3ec0e9cb16 content::RunNamedProcessTypeMain() #20 0x7f3ec0e9ebff content::ContentMainRunnerImpl::Run() #21 0x7f3ec0e9b82a content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #22 0x7f3eb163ea27 service_manager::Main() #23 0x7f3ec0e9c63b content::ContentMain() #24 0x000004e86fef content::BrowserTestBase::SetUp() #25 0x000003d73fac InProcessBrowserTest::SetUp() #26 0x0000008592ae _ZN7testing8internal12InvokeHelperIRKNSt7__debug6vectorIPN12user_manager4UserESaIS6_EEESt5tupleIJEEE12InvokeMethodIN8chromeos15MockUserManagerEMSG_KFSA_vEEESA_PT_T0_RKSC_ #27 0x000005039b52 testing::internal::HandleExceptionsInMethodIfSupported<>() #28 0x00000502ee54 testing::Test::Run() #29 0x00000502f5dd testing::TestInfo::Run() #30 0x00000502fb7f testing::TestCase::Run() #31 0x000005034eec testing::internal::UnitTestImpl::RunAllTests() #32 0x00000504918e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #33 0x00000503b142 testing::internal::HandleExceptionsInMethodIfSupported<>() #34 0x000005034b8f testing::UnitTest::Run() #35 0x000003d8f911 RUN_ALL_TESTS() #36 0x000003d8e692 base::TestSuite::Run() #37 0x000003d232b2 ChromeTestSuiteRunner::RunTestSuite() #38 0x000003d23399 ChromeTestLauncherDelegate::RunTestSuite() #39 0x000004f14d82 content::LaunchTests() #40 0x000003d23669 LaunchChromeTests() #41 0x000003d1c6e4 main #42 0x7f3ead8c3f45 __libc_start_main #43 0x000000839854 <unknown>
,
May 4 2017
This means that aura::Env::Mode is LOCAL instead of MUS when running some cases in mash_browser_tests? Not sure why that is exactly. I haven't been able to reproduce this myself as one of the test cases in our filter file trigger the error.
,
May 4 2017
none of*
,
May 4 2017
It's strange. It reproduces when I run the entire test suite:
./out/${OUT_DIR}/browser_tests --test-launcher-bot-mode --override-use-gl-with-osmesa-for-tests --run-in-mash --service-overrides=chrome/app/mash/mash_service_overrides.json --test-launcher-filter-file=testing/buildbot/filters/mash.browser_tests.filter --use-test-config
But I haven't seen it when running a smaller subset. Anytime I give a smaller gtest_filter things pass smoothly.
I wonder if this is racey. I have seen this on bots before. I also have some local changes which alter the creation order of ServiceManager
,
May 4 2017
Can confirm that we are creating some instance of aura::env with local. Hunting further. Will post updates
,
May 8 2017
,
May 24 2017
Local aura being incorrectly set was fixed by: https://codereview.chromium.org/2858103002/
,
Aug 1 2017
,
Jan 22 2018
,
Feb 26 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kylec...@chromium.org
, May 4 2017Status: Started (was: Untriaged)