New issue
Advanced search Search tips

Issue 718465 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add http response code metric in download system

Project Member Reported by xingliu@chromium.org, May 4 2017

Issue description

Currently we notice an issue according to metric data that parallel
download feature has a higher SERVER_FAIL interruption type.

we would like to know more details about the http response code from
the server to analyze the cause. This metric only applies to download
requests and will also be helpful to track general download system health.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/503e20c58c8fdae480d5e7bbc538365f17e32fa1

commit 503e20c58c8fdae480d5e7bbc538365f17e32fa1
Author: xingliu <xingliu@chromium.org>
Date: Sat May 06 19:57:24 2017

Add a metric to record http response code for download requests.

Currently we notice an issue according to metric data that parallel
download feature has a higher SERVER_FAIL interruption type.

we would like to know more details about the http response code from
the server to analyze the cause. This metric only applies to download
requests and will also be helpful to track general download system health.

BUG= 718465 

Review-Url: https://codereview.chromium.org/2862743002
Cr-Commit-Position: refs/heads/master@{#469888}

[modify] https://crrev.com/503e20c58c8fdae480d5e7bbc538365f17e32fa1/content/browser/download/download_request_core.cc
[modify] https://crrev.com/503e20c58c8fdae480d5e7bbc538365f17e32fa1/content/browser/download/download_stats.cc
[modify] https://crrev.com/503e20c58c8fdae480d5e7bbc538365f17e32fa1/content/browser/download/download_stats.h
[modify] https://crrev.com/503e20c58c8fdae480d5e7bbc538365f17e32fa1/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 7 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49b3271814acb74884e3781628c155775b7f7a0a

commit 49b3271814acb74884e3781628c155775b7f7a0a
Author: Xing Liu <xingliu@chromium.org>
Date: Mon May 08 16:51:22 2017

Add a metric to record http response code for download requests.

Currently we notice an issue according to metric data that parallel
download feature has a higher SERVER_FAIL interruption type.

we would like to know more details about the http response code from
the server to analyze the cause. This metric only applies to download
requests and will also be helpful to track general download system health.

BUG= 718465 

Review-Url: https://codereview.chromium.org/2862743002
Cr-Commit-Position: refs/heads/master@{#469888}
(cherry picked from commit 503e20c58c8fdae480d5e7bbc538365f17e32fa1)

Review-Url: https://codereview.chromium.org/2867803002 .
Cr-Commit-Position: refs/branch-heads/3071@{#449}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/49b3271814acb74884e3781628c155775b7f7a0a/content/browser/download/download_request_core.cc
[modify] https://crrev.com/49b3271814acb74884e3781628c155775b7f7a0a/content/browser/download/download_stats.cc
[modify] https://crrev.com/49b3271814acb74884e3781628c155775b7f7a0a/content/browser/download/download_stats.h
[modify] https://crrev.com/49b3271814acb74884e3781628c155775b7f7a0a/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment