Fix should hopefully be easy.  Guessing the thing to click on isn't ready immediately.  Investigating.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbb2753cfb8b54c01b163ef7e443b95a5f570c75

commit cbb2753cfb8b54c01b163ef7e443b95a5f570c75
Author: johnme <johnme@chromium.org>
Date: Thu May 04 16:38:04 2017

Mark a FirstRunIntegrationTest flaky

FirstRunIntegrationTest.testDefaultSearchEngine_ShowExisting was
recently added by https://codereview.chromium.org/2844323003.

However it's been consistently failing on Lollipop Phone Tester, and
flakily failing on other Android bots, so this patch disables it.

BUG= 718461 
TBR=dfalcantara
NOTRY=true
SKIPTREECHECKS=true

Review-Url: https://codereview.chromium.org/2863653002
Cr-Commit-Position: refs/heads/master@{#469356}

[modify] https://crrev.com/cbb2753cfb8b54c01b163ef7e443b95a5f570c75/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71e4f4f52608631a084e4097585ed5fdc58d0a87

commit 71e4f4f52608631a084e4097585ed5fdc58d0a87
Author: dfalcantara <dfalcantara@chromium.org>
Date: Thu May 04 17:40:19 2017

🔍 Fix flaky FirstRunIntegrationTest

Seems the option isn't ready to click on immediately.
Wait until the option is non-null before moving forward.

BUG= 718461 

Review-Url: https://codereview.chromium.org/2861003002
Cr-Commit-Position: refs/heads/master@{#469374}

[modify] https://crrev.com/71e4f4f52608631a084e4097585ed5fdc58d0a87/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java

 Issue 718485  has been merged into this issue.

Seems to be fixed.  At least it started passing on the Lollipop phone bot where it used to constantly fail.  Still monitoring; will re-open if it continues being problematic.

https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/12588

:( Seems to have started flaking again...

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76feb802adee55d10fbd4dbfe05e1f650bc2bc14

commit 76feb802adee55d10fbd4dbfe05e1f650bc2bc14
Author: mattcary <mattcary@chromium.org>
Date: Tue May 30 09:55:37 2017

Disabling FirstRunIntegrationTest.testDefaultSearchEngine_ShowExisting.

It has started flaking again.

BUG= 718461 
TBR=dfalcantara@chromium.org,tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2913663003
Cr-Commit-Position: refs/heads/master@{#475482}

[modify] https://crrev.com/76feb802adee55d10fbd4dbfe05e1f650bc2bc14/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java

I'll take a look at this.

Hmm...it looks like "something" is calling LocaleManager#showSearchEnginePromoIfNeeded since FirstRun shouldn't be calling into the Dialog flow.

Flakiness dashboard link:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testDefaultSearchEngine_ShowExisting

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FMarshmallow_64_bit_Tester%2F12559%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_apk_on_Android%2F0%2Flogs%2Forg.chromium.chrome.browser.firstrun.FirstRunIntegrationTest_testDefaultSearchEngine_ShowExisting%2F0

android.view.WindowManager$BadTokenException: Unable to add window -- token android.os.BinderProxy@e0c9bf6 is not valid; is your activity running?
	at android.view.ViewRootImpl.setView(ViewRootImpl.java:567)
	at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:310)
	at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:85)
	at android.app.Dialog.show(Dialog.java:319)
	at org.chromium.chrome.browser.locale.DefaultSearchEnginePromoDialog.show(DefaultSearchEnginePromoDialog.java:109)
	at org.chromium.chrome.browser.locale.DefaultSearchEnginePromoDialog$1.onTemplateUrlServiceLoaded(DefaultSearchEnginePromoDialog.java:59)
	at org.chromium.chrome.browser.search_engines.TemplateUrlService$1.run(TemplateUrlService.java:296)
	at android.os.Handler.handleCallback(Handler.java:739)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:148)
	at android.app.ActivityThread.main(ActivityThread.java:5417)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Earliest failure I found:
https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/12504

The test does launch CTA at the end, so maybe this crash is just caught as the test is being shutdown.  We should fix it so we don't attempt to show the dialog if the activity has been destroyed/shutdown.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc06b2e2dbd546ff00c8d7626fb915d86136aede

commit bc06b2e2dbd546ff00c8d7626fb915d86136aede
Author: tedchoc <tedchoc@chromium.org>
Date: Tue May 30 19:14:39 2017

Do not attempt to show search engine dialog if activity is dead.

BUG= 718461 

Review-Url: https://codereview.chromium.org/2911273002
Cr-Commit-Position: refs/heads/master@{#475624}

[modify] https://crrev.com/bc06b2e2dbd546ff00c8d7626fb915d86136aede/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
[modify] https://crrev.com/bc06b2e2dbd546ff00c8d7626fb915d86136aede/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java

Has not flaked since my patch landed.

[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.

Merge request for https://bugs.chromium.org/p/chromium/issues/detail?id=718461#c12

Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21f084920b4efa522b2cb60e0f779d5cec05255c

commit 21f084920b4efa522b2cb60e0f779d5cec05255c
Author: Ted Choc <tedchoc@google.com>
Date: Mon Jun 05 20:46:37 2017

Do not attempt to show search engine dialog if activity is dead.

BUG= 718461 

Review-Url: https://codereview.chromium.org/2911273002
Cr-Original-Commit-Position: refs/heads/master@{#475624}
Review-Url: https://codereview.chromium.org/2924693002 .
Cr-Commit-Position: refs/branch-heads/3112@{#168}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/21f084920b4efa522b2cb60e0f779d5cec05255c/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java