New issue
Advanced search Search tips

Issue 718460 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 612322



Sign in to add a comment

Change the accelerometer at //device/generic_sensor to only update the blink side when the sensor value changes

Project Member Reported by juncai@chromium.org, May 4 2017

Issue description

Based on the discussion at:
https://codereview.chromium.org/2847253002/diff/100001/device/generic_sensor/platform_sensor_accelerometer_mac.cc
Since the report mode is: mojom::ReportingMode::ON_CHANGE, the accelerometer needs to only update the blink side when the sensor value changes.
 
Blocking: 612322

Comment 2 by juncai@chromium.org, May 13 2017

Status: Started (was: Assigned)

Comment 3 by juncai@chromium.org, May 13 2017

Components: Blink>Sensor
Project Member

Comment 4 by bugdroid1@chromium.org, May 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94de540ef9694dd6d2680dc6da1375e982d7577e

commit 94de540ef9694dd6d2680dc6da1375e982d7577e
Author: juncai <juncai@chromium.org>
Date: Sat May 13 05:45:37 2017

[Device Service] Add ACCELEROMETER implementation on Mac to //device/generic_sensor

At //device/sensors, DeviceOrientation Event is implemented on Mac using
sudden motion sensor, and it is a kind of ACCELEROMETER. And
//device/generic_sensor has ACCELEROMETER sensor type, but the Mac
implementation is missing. In order to make //content/renderer/device_sensors
depend on //device/generic_sensor instead of //device/sensors, this CL adds
ACCELEROMETER sensor implementation to //device/generic_sensor on Mac.

BUG= 721427 ,  718460 

Review-Url: https://codereview.chromium.org/2880743003
Cr-Commit-Position: refs/heads/master@{#471567}

[modify] https://crrev.com/94de540ef9694dd6d2680dc6da1375e982d7577e/device/generic_sensor/BUILD.gn
[modify] https://crrev.com/94de540ef9694dd6d2680dc6da1375e982d7577e/device/generic_sensor/DEPS
[add] https://crrev.com/94de540ef9694dd6d2680dc6da1375e982d7577e/device/generic_sensor/platform_sensor_accelerometer_mac.cc
[add] https://crrev.com/94de540ef9694dd6d2680dc6da1375e982d7577e/device/generic_sensor/platform_sensor_accelerometer_mac.h
[modify] https://crrev.com/94de540ef9694dd6d2680dc6da1375e982d7577e/device/generic_sensor/platform_sensor_provider_mac.cc

Comment 5 by juncai@chromium.org, May 13 2017

Status: Fixed (was: Started)
Components: Internals>Services>Device

Sign in to add a comment