New issue
Advanced search Search tips

Issue 718457 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 612322



Sign in to add a comment

Remove mutable reference argument for //device/generic_sensor

Project Member Reported by juncai@chromium.org, May 4 2017

Issue description

Based on the comment at:
https://codereview.chromium.org/2847253002/diff/100001/device/generic_sensor/platform_sensor_reader_win.cc
Google C++ coding style does not permit mutable reference arguments. So need to fix it.
 
Labels: DeviceService

Comment 2 by juncai@chromium.org, May 13 2017

Components: Blink>Sensor

Comment 3 by juncai@chromium.org, May 18 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28a065e82bfd0d01fb5d7096ce2311ee6aeb92a7

commit 28a065e82bfd0d01fb5d7096ce2311ee6aeb92a7
Author: juncai <juncai@chromium.org>
Date: Thu May 18 20:55:42 2017

Remove mutable reference argument for //device/generic_sensor/platform_sensor_reader_win.*

Google C++ coding style does not permit mutable reference arguments.
This CL fixes it for //device/generic_sensor/platform_sensor_reader_win.*

BUG= 718457 

Review-Url: https://codereview.chromium.org/2893793002
Cr-Commit-Position: refs/heads/master@{#472926}

[modify] https://crrev.com/28a065e82bfd0d01fb5d7096ce2311ee6aeb92a7/device/generic_sensor/platform_sensor_reader_win.cc
[modify] https://crrev.com/28a065e82bfd0d01fb5d7096ce2311ee6aeb92a7/device/generic_sensor/platform_sensor_reader_win.h

Comment 5 by juncai@chromium.org, May 18 2017

Status: Fixed (was: Started)
Components: Internals>Services>Device

Sign in to add a comment