Clean up webkitpy executive mock calls. |
||||
Issue descriptionThe code in question is here: https://chromium.googlesource.com/chromium/src/+/7bcba1f80eb3c41b069af63200a2640e2bff7b40/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py Currently, Mock keeps a list of "calls" that are made, in the form of argument lists. If calls are made in batches, the list contains lists of argument lists instead. After this CL (https://codereview.chromium.org/2859703002/) lands, argument lists will be replaced with "MockCall" objects. The "calls" list will then contain either MockCall or lists of MockCall respectively. Part of the aforementioned CL replaces the "calls" variable with "full_calls" and exposes a generated "calls" property to maintain API compatibility with existing test code. If restructuring is done here, this hack can probably be removed as well.
,
Jul 21 2017
,
Jul 23
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
dnj@, do you plan to work on this? It'll keep getting poked every year :)
,
Jul 25
I don't expect dnj will work on this. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, May 4 2017