New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718454 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
not available
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

ChromeActivityTestCaseBase not calling super.tearDown

Project Member Reported by jbudorick@chromium.org, May 4 2017

Issue description

Looks like some of the JUnit4 conversion changes lost it in the shuffle: https://chromium.googlesource.com/chromium/src/+/8dc40e2e6496012195f8b28db158e787486fbc07
 
np, thanks for the quick fix :)
Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/240c255d33ba778844e6e86309400c4932298f6d

commit 240c255d33ba778844e6e86309400c4932298f6d
Author: yolandyan <yolandyan@chromium.org>
Date: Thu May 04 18:13:12 2017

Fix ChromeActivityTestCaseBase tearDown mistake

In the JUnit4 conversion CL (https://codereview.chromium.org/2815453003)
super.tearDown() call was mistakenly removed.

BUG= 718454 

Review-Url: https://codereview.chromium.org/2861433006
Cr-Commit-Position: refs/heads/master@{#469379}

[modify] https://crrev.com/240c255d33ba778844e6e86309400c4932298f6d/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java

Status: Fixed (was: Assigned)

Sign in to add a comment