WebVR: Remove fullscreen requirement from listening for vrdisplayactivate within a frame |
|||||||
Issue descriptionWe missed some code when removing the fullscreen hacks, so fullscreen is still mistakenly a requirement for listening for vrdisplayactivate.
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8847dabd9aef1075e157dced4d511a77308dedc2 commit 8847dabd9aef1075e157dced4d511a77308dedc2 Author: mthiesse <mthiesse@chromium.org> Date: Thu May 04 18:47:29 2017 Remove fullscreen requirement from listening for vrdisplayactivate inside a frame. BUG= 718445 Review-Url: https://codereview.chromium.org/2862863002 Cr-Commit-Position: refs/heads/master@{#469399} [modify] https://crrev.com/8847dabd9aef1075e157dced4d511a77308dedc2/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
,
May 4 2017
,
May 4 2017
,
May 5 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac83b7cb79d0de2130143ce662d82bcf593201cf commit ac83b7cb79d0de2130143ce662d82bcf593201cf Author: Michael Thiessen <mthiesse@google.com> Date: Fri May 05 19:10:20 2017 Remove fullscreen requirement from listening for vrdisplayactivate inside a frame. BUG= 718445 Review-Url: https://codereview.chromium.org/2862863002 Cr-Commit-Position: refs/heads/master@{#469399} (cherry picked from commit 8847dabd9aef1075e157dced4d511a77308dedc2) Review-Url: https://codereview.chromium.org/2860163007 . Cr-Commit-Position: refs/branch-heads/3071@{#423} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/ac83b7cb79d0de2130143ce662d82bcf593201cf/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
,
May 5 2017
,
Jul 4
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ddorwin@chromium.org
, May 4 2017