Integrate the stability instrumentation with Crashpad so it is collected on crash.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/531ed20b52b93b78c30a73e37ccf968238c25d84 commit 531ed20b52b93b78c30a73e37ccf968238c25d84 Author: manzagop <manzagop@chromium.org> Date: Fri May 05 18:37:11 2017 Rework GetStabilityFileForProcess for use by Crashpad integration The stability file naming code is needed both to know which file to record to and to know which file to collect on crash (note that for the postmortem case we simply glob files). Note: changing the file naming is fine wrt live code as the only current consumption of stability files is via glob on the postmortem path. BUG= 718437 Review-Url: https://codereview.chromium.org/2860863003 Cr-Commit-Position: refs/heads/master@{#469733} [modify] https://crrev.com/531ed20b52b93b78c30a73e37ccf968238c25d84/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn [modify] https://crrev.com/531ed20b52b93b78c30a73e37ccf968238c25d84/components/browser_watcher/BUILD.gn [modify] https://crrev.com/531ed20b52b93b78c30a73e37ccf968238c25d84/components/browser_watcher/stability_paths.cc [modify] https://crrev.com/531ed20b52b93b78c30a73e37ccf968238c25d84/components/browser_watcher/stability_paths.h [modify] https://crrev.com/531ed20b52b93b78c30a73e37ccf968238c25d84/components/crash/content/app/BUILD.gn [modify] https://crrev.com/531ed20b52b93b78c30a73e37ccf968238c25d84/components/metrics/BUILD.gn [modify] https://crrev.com/531ed20b52b93b78c30a73e37ccf968238c25d84/components/metrics/execution_phase.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a50215b18581e0623f549a2aaf8586bdfe755db9 commit a50215b18581e0623f549a2aaf8586bdfe755db9 Author: manzagop <manzagop@chromium.org> Date: Mon May 08 13:01:15 2017 Make some execution_phase.cc includes windows only This is a follow up to https://codereview.chromium.org/2860863003/. Surprisingly the build isn't broken. BUG= 718437 Review-Url: https://codereview.chromium.org/2862413002 Cr-Commit-Position: refs/heads/master@{#469969} [modify] https://crrev.com/a50215b18581e0623f549a2aaf8586bdfe755db9/components/metrics/execution_phase.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85e629e964e7da6d8a3a05b713e2aef62f976595 commit 85e629e964e7da6d8a3a05b713e2aef62f976595 Author: manzagop <manzagop@chromium.org> Date: Tue May 09 22:11:48 2017 Update stability report dumper so it handles non-postmortem minidumps BUG= 718437 Review-Url: https://codereview.chromium.org/2866163002 Cr-Commit-Position: refs/heads/master@{#470428} [modify] https://crrev.com/85e629e964e7da6d8a3a05b713e2aef62f976595/PRESUBMIT.py [modify] https://crrev.com/85e629e964e7da6d8a3a05b713e2aef62f976595/PRESUBMIT_test.py [modify] https://crrev.com/85e629e964e7da6d8a3a05b713e2aef62f976595/components/browser_watcher/BUILD.gn [rename] https://crrev.com/85e629e964e7da6d8a3a05b713e2aef62f976595/components/browser_watcher/dump_stability_report_main_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b69ce5fc7a7e267f2f893df6954c3787d5f2d2f commit 8b69ce5fc7a7e267f2f893df6954c3787d5f2d2f Author: manzagop <manzagop@chromium.org> Date: Thu May 18 12:23:38 2017 Relocate Windows ProcessNeedsProfileDir to install_static This is pre-work to enable adding the user data directory to InstallDetails in the context of http://crrev.com/2867063002 BUG= 718437 Review-Url: https://codereview.chromium.org/2884333004 Cr-Commit-Position: refs/heads/master@{#472780} [modify] https://crrev.com/8b69ce5fc7a7e267f2f893df6954c3787d5f2d2f/chrome/common/chrome_paths_win.cc [modify] https://crrev.com/8b69ce5fc7a7e267f2f893df6954c3787d5f2d2f/chrome/install_static/install_util.cc [modify] https://crrev.com/8b69ce5fc7a7e267f2f893df6954c3787d5f2d2f/chrome/install_static/install_util.h [modify] https://crrev.com/8b69ce5fc7a7e267f2f893df6954c3787d5f2d2f/chrome/install_static/install_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fecdf607e706474b65a4d26e554f0504aead3f3e commit fecdf607e706474b65a4d26e554f0504aead3f3e Author: manzagop <manzagop@chromium.org> Date: Thu May 25 19:43:22 2017 Stability instrumentation Crashpad integration The stability instrumentation is about Chrome recording internal state to a memory mapped file as it is running. It is currently used experimentally on Windows only. This CL makes use of Crashpad's extensibility mechanism to collect information from the stability file on crash, and include it within the crash report as an additional minidump user stream. DETAILS: - The browser process now passes the user data dir to the crash handler's command line. - The handler process creates the Crashpad extension that will search for a stability file on any crash. If the file is found (currently only possible for instrumented browser processes), it is collected and the information is added to the crash report. On successful collection the stability file is deleted. TESTING - launch chrome with the stability instrumentation: chrome.exe --user-data-dir=<data-dir> --enable-features=StabilityDebugging - validate the presence of the stability file in <data-dir>/Stability - trigger a crash (visit chrome://inducebrowsercrashforrealz) - validate the deletion of the the stability file in <data-dir>/Stability - validate the presence of a crash report in <data-dir>/Crashpad/Reports and ensure it contains the additional stream, either with dumpchk.exe or the dump_stability build target. BUG= 718437 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2867063002 Cr-Commit-Position: refs/heads/master@{#474759} [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/app/chrome_crash_reporter_client_win.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/app/chrome_exe_main_win.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/install_static/install_details.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/install_static/install_details.h [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/install_static/install_util.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/install_static/install_util.h [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/install_static/install_util_unittest.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/install_static/product_install_details.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/install_static/user_data_dir.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/install_static/user_data_dir.h [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/install_static/user_data_dir_win_unittest.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/installer/setup/installer_crash_reporting.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome_elf/chrome_elf.def [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/chrome_elf/chrome_elf_main.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/browser_watcher/BUILD.gn [add] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/browser_watcher/minidump_user_streams.h [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/browser_watcher/postmortem_minidump_writer_win.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/browser_watcher/stability_report_extractor.cc [add] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/browser_watcher/stability_report_user_stream_data_source.cc [add] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/browser_watcher/stability_report_user_stream_data_source.h [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/crash/content/app/BUILD.gn [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/crash/content/app/DEPS [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/crash/content/app/crashpad.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/crash/content/app/crashpad.h [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/crash/content/app/crashpad_mac.mm [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/crash/content/app/crashpad_win.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/crash/content/app/run_as_crashpad_handler_win.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/components/crash/content/app/run_as_crashpad_handler_win.h [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/headless/app/headless_shell.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/headless/lib/headless_content_main_delegate.cc [modify] https://crrev.com/fecdf607e706474b65a4d26e554f0504aead3f3e/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/332af9ce8cf255ba7dc1604ab4a56e1c597ed338 commit 332af9ce8cf255ba7dc1604ab4a56e1c597ed338 Author: Scott Graham <scottmg@chromium.org> Date: Fri Jul 28 15:49:51 2017 Revert "Stability instrumentation Crashpad integration" This reverts commit fecdf607e706474b65a4d26e554f0504aead3f3e. Suspected of causing crashes on Win7 Stable 60 when UserDataDir is set to have expandable ${variables} in it. :( This will need to be back merged to 60 and 61. Bug: 718437 , 748949 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Id379a7c167f536154af1c67aa3dc6e17ca516934 Reviewed-on: https://chromium-review.googlesource.com/589775 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Shield <robertshield@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#490410} [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/app/chrome_crash_reporter_client_win.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/app/chrome_exe_main_win.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/chrome_watcher/chrome_watcher_main.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/install_static/install_details.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/install_static/install_details.h [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/install_static/install_util.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/install_static/install_util.h [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/install_static/install_util_unittest.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/install_static/product_install_details.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/install_static/user_data_dir.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/install_static/user_data_dir.h [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/install_static/user_data_dir_win_unittest.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/installer/setup/installer_crash_reporting.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome_elf/chrome_elf.def [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/chrome_elf/chrome_elf_main.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/browser_watcher/BUILD.gn [delete] https://crrev.com/e0db29894d5e4cbdeafc786d3ab0b4205083d419/components/browser_watcher/minidump_user_streams.h [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/browser_watcher/postmortem_minidump_writer_win.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/browser_watcher/stability_report_extractor.cc [delete] https://crrev.com/e0db29894d5e4cbdeafc786d3ab0b4205083d419/components/browser_watcher/stability_report_user_stream_data_source.cc [delete] https://crrev.com/e0db29894d5e4cbdeafc786d3ab0b4205083d419/components/browser_watcher/stability_report_user_stream_data_source.h [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/crash/content/app/BUILD.gn [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/crash/content/app/DEPS [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/crash/content/app/crashpad.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/crash/content/app/crashpad.h [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/crash/content/app/crashpad_mac.mm [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/crash/content/app/crashpad_win.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/crash/content/app/run_as_crashpad_handler_win.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/components/crash/content/app/run_as_crashpad_handler_win.h [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/headless/app/headless_shell.cc [modify] https://crrev.com/332af9ce8cf255ba7dc1604ab4a56e1c597ed338/headless/lib/headless_content_main_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47b9c67f3a9afdb490ae69900c7cac262688b996 commit 47b9c67f3a9afdb490ae69900c7cac262688b996 Author: Scott Graham <scottmg@chromium.org> Date: Mon Jul 31 23:15:42 2017 Revert "Stability instrumentation Crashpad integration" This reverts commit fecdf607e706474b65a4d26e554f0504aead3f3e. Suspected of causing crashes on Win7 Stable 60 when UserDataDir is set to have expandable ${variables} in it. :( This will need to be back merged to 60 and 61. TBR=scottmg@chromium.org (cherry picked from commit 332af9ce8cf255ba7dc1604ab4a56e1c597ed338) Bug: 718437 , 748949 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Id379a7c167f536154af1c67aa3dc6e17ca516934 Reviewed-on: https://chromium-review.googlesource.com/589775 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Shield <robertshield@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490410} Reviewed-on: https://chromium-review.googlesource.com/595142 Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#197} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/app/chrome_crash_reporter_client_win.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/app/chrome_exe_main_win.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/chrome_watcher/chrome_watcher_main.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/install_static/install_details.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/install_static/install_details.h [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/install_static/install_util.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/install_static/install_util.h [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/install_static/install_util_unittest.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/install_static/product_install_details.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/install_static/user_data_dir.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/install_static/user_data_dir.h [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/install_static/user_data_dir_win_unittest.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/installer/setup/installer_crash_reporting.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome_elf/chrome_elf.def [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/chrome_elf/chrome_elf_main.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/browser_watcher/BUILD.gn [delete] https://crrev.com/0efea6c59691b7a81801445595eb7f84b2da951a/components/browser_watcher/minidump_user_streams.h [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/browser_watcher/postmortem_minidump_writer_win.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/browser_watcher/stability_report_extractor.cc [delete] https://crrev.com/0efea6c59691b7a81801445595eb7f84b2da951a/components/browser_watcher/stability_report_user_stream_data_source.cc [delete] https://crrev.com/0efea6c59691b7a81801445595eb7f84b2da951a/components/browser_watcher/stability_report_user_stream_data_source.h [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/crash/content/app/BUILD.gn [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/crash/content/app/DEPS [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/crash/content/app/crashpad.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/crash/content/app/crashpad.h [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/crash/content/app/crashpad_mac.mm [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/crash/content/app/crashpad_win.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/crash/content/app/run_as_crashpad_handler_win.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/components/crash/content/app/run_as_crashpad_handler_win.h [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/headless/app/headless_shell.cc [modify] https://crrev.com/47b9c67f3a9afdb490ae69900c7cac262688b996/headless/lib/headless_content_main_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44e7e44ccad3609ca8acfccfa88768488bb25463 commit 44e7e44ccad3609ca8acfccfa88768488bb25463 Author: Scott Graham <scottmg@chromium.org> Date: Mon Jul 31 23:53:02 2017 Revert "Stability instrumentation Crashpad integration" This reverts commit fecdf607e706474b65a4d26e554f0504aead3f3e. Suspected of causing crashes on Win7 Stable 60 when UserDataDir is set to have expandable ${variables} in it. :( This will need to be back merged to 60 and 61. TBR=scottmg@chromium.org (cherry picked from commit 332af9ce8cf255ba7dc1604ab4a56e1c597ed338) Bug: 718437 , 748949 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Id379a7c167f536154af1c67aa3dc6e17ca516934 Reviewed-on: https://chromium-review.googlesource.com/589775 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Shield <robertshield@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490410} Reviewed-on: https://chromium-review.googlesource.com/595145 Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#698} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/app/chrome_crash_reporter_client_win.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/app/chrome_exe_main_win.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/install_static/install_details.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/install_static/install_details.h [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/install_static/install_util.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/install_static/install_util.h [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/install_static/install_util_unittest.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/install_static/product_install_details.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/install_static/user_data_dir.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/install_static/user_data_dir.h [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/install_static/user_data_dir_win_unittest.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/installer/setup/installer_crash_reporting.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome_elf/chrome_elf.def [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/chrome_elf/chrome_elf_main.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/browser_watcher/BUILD.gn [delete] https://crrev.com/d929afacff82766b8dd0ee27d2ccd8a3e297c805/components/browser_watcher/minidump_user_streams.h [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/browser_watcher/postmortem_minidump_writer_win.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/browser_watcher/stability_report_extractor.cc [delete] https://crrev.com/d929afacff82766b8dd0ee27d2ccd8a3e297c805/components/browser_watcher/stability_report_user_stream_data_source.cc [delete] https://crrev.com/d929afacff82766b8dd0ee27d2ccd8a3e297c805/components/browser_watcher/stability_report_user_stream_data_source.h [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/crash/content/app/BUILD.gn [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/crash/content/app/DEPS [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/crash/content/app/crashpad.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/crash/content/app/crashpad.h [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/crash/content/app/crashpad_mac.mm [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/crash/content/app/crashpad_win.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/crash/content/app/run_as_crashpad_handler_win.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/components/crash/content/app/run_as_crashpad_handler_win.h [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/headless/app/headless_shell.cc [modify] https://crrev.com/44e7e44ccad3609ca8acfccfa88768488bb25463/headless/lib/headless_content_main_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e commit 81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Thu Aug 03 17:54:55 2017 Re-land Stability instrumentation Crashpad integration This is copy of https://codereview.chromium.org/2867063002 with all the install_static refactoring removed to avoid bug:748949. Bug: 718437 TBR: alexclarke@chromium.org Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I3341f9af6a73dd83fc631bbde5f5b0473ff9de55 Reviewed-on: https://chromium-review.googlesource.com/591827 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Pierre-Antoine Manzagol (departed) <manzagop@chromium.org> Cr-Commit-Position: refs/heads/master@{#491787} [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/chrome/app/chrome_crash_reporter_client_win.cc [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/chrome/app/chrome_exe_main_win.cc [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/chrome/installer/setup/installer_crash_reporting.cc [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/browser_watcher/BUILD.gn [add] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/browser_watcher/minidump_user_streams.h [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/browser_watcher/postmortem_minidump_writer_win.cc [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/browser_watcher/stability_report_extractor.cc [add] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/browser_watcher/stability_report_user_stream_data_source.cc [add] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/browser_watcher/stability_report_user_stream_data_source.h [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/crash/content/app/BUILD.gn [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/crash/content/app/DEPS [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/crash/content/app/crashpad.cc [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/crash/content/app/crashpad.h [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/crash/content/app/crashpad_mac.mm [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/crash/content/app/crashpad_win.cc [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/crash/content/app/run_as_crashpad_handler_win.cc [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/components/crash/content/app/run_as_crashpad_handler_win.h [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/headless/app/headless_shell.cc [modify] https://crrev.com/81d9ac534cd9ddfb77ef6a504f0a28d37b6be01e/headless/lib/headless_content_main_delegate.cc
I'm going to call this one done.
Comment 1 by bugdroid1@chromium.org
, May 5 2017