Dictionary answers on Android are covered by 'go to' arrow |
||||||||
Issue descriptionChrome Version: 60.0.3088.0 (ToT) OS: Android N What steps will reproduce the problem? (1) Enter a definition request in the Omnibox e.g. "definition of socialism" (2) (3) What is the expected result? You may see a dictionary answer among the suggestions. (There's no guarantee of this.) If so, the text in the definition shouldn't be covered by other UI elements. What happens instead? If a definition is displayed, it is covered by the up-left arrow on the right.
,
May 4 2017
,
May 5 2017
,
May 5 2017
,
May 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d98981b9ab09719407adcb63f639276590f4263b commit d98981b9ab09719407adcb63f639276590f4263b Author: krb <krb@chromium.org> Date: Sat May 06 19:09:57 2017 [android omnibox] Move width calculation to onMeasure step The Android text renderer runs in the ::measure() step. If the View width is changed after this, in the layout or draw step, the text is not re-laid out; it is truncated. This change moves up the calculation. BUG= 718432 Review-Url: https://codereview.chromium.org/2866643002 Cr-Commit-Position: refs/heads/master@{#469869} [modify] https://crrev.com/d98981b9ab09719407adcb63f639276590f4263b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
,
May 6 2017
,
May 8 2017
"Fixed" is the usual status when landing a fix. If it requires verification, Chrome Test will usually handle that. If you prefer to mark it verified, please provide the details of the device and software (OS and Chrome versions) that the fix was verified on.
,
May 8 2017
,
May 8 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9de10b9bb6b8b343a212643cad39877e0a134c41 commit 9de10b9bb6b8b343a212643cad39877e0a134c41 Author: Kevin Bailey <krb@chromium.org> Date: Mon May 08 21:47:39 2017 Cherry-picked merge request for M59 [android omnibox] Move width calculation to onMeasure step The Android text renderer runs in the ::measure() step. If the View width is changed after this, in the layout or draw step, the text is not re-laid out; it is truncated. This change moves up the calculation. BUG= 718432 Review-Url: https://codereview.chromium.org/2866643002 Cr-Commit-Position: refs/heads/master@{#469869} (cherry picked from commit d98981b9ab09719407adcb63f639276590f4263b) Review-Url: https://codereview.chromium.org/2867923002 . Cr-Commit-Position: refs/branch-heads/3071@{#467} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/9de10b9bb6b8b343a212643cad39877e0a134c41/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
,
May 10 2017
Verified on Chrome:59.0.3071.49 Device: Huawei P8 Lite (ALE-L23)/5.0.1 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jdonnelly@chromium.org
, May 4 2017Owner: k...@chromium.org
Status: Assigned (was: Untriaged)