Do not send activation event when a new shell_surface is created. |
||||||||||
Issue descriptionm58, m59 and ToT https://codereview.chromium.org/2825923002 suppressed sending the activation back to android, but the same thing happen when a new shell_surface is created.
,
May 4 2017
If this is a merge request, consider it merge approved for 58, it appears we need this for CTS.
,
May 5 2017
yes, will do.
,
May 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67679038561e87a38508710c0058477333b40eac commit 67679038561e87a38508710c0058477333b40eac Author: oshima <oshima@chromium.org> Date: Sat May 06 00:13:16 2017 Don't send activation event when created The new task may be already created on Android side, which can deactivate a new task on Android side. This CL suppresses the activation event for creation as well as activation request. R=reveman@chromium.org BUG= 718429 TEST=Run cts test "CtsUiHostTestCases". It no longer fails. Review-Url: https://codereview.chromium.org/2855883009 Cr-Commit-Position: refs/heads/master@{#469823} [modify] https://crrev.com/67679038561e87a38508710c0058477333b40eac/components/exo/wayland/server.cc
,
May 6 2017
,
May 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/169f4fac454487e4015b7f0568bd4363996dfc0c commit 169f4fac454487e4015b7f0568bd4363996dfc0c Author: Mitsuru Oshima <oshima@chromium.org> Date: Sat May 06 02:09:47 2017 Don't send activation event when created The new task may be already created on Android side, which can deactivate a new task on Android side. This CL suppresses the activation event for creation as well as activation request. R=reveman@chromium.org BUG= 718429 TEST=Run cts test "CtsUiHostTestCases". It no longer fails. Review-Url: https://codereview.chromium.org/2855883009 Cr-Commit-Position: refs/heads/master@{#469823} (cherry picked from commit 67679038561e87a38508710c0058477333b40eac) Review-Url: https://codereview.chromium.org/2868623002 . Cr-Commit-Position: refs/branch-heads/3029@{#812} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/169f4fac454487e4015b7f0568bd4363996dfc0c/components/exo/wayland/server.cc
,
May 7 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 8 2017
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77c20f176331e7e12d466b559d0af6d204676fd8 commit 77c20f176331e7e12d466b559d0af6d204676fd8 Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon May 08 04:49:48 2017 Don't send activation event when created The new task may be already created on Android side, which can deactivate a new task on Android side. This CL suppresses the activation event for creation as well as activation request. R=reveman@chromium.org BUG= 718429 TEST=Run cts test "CtsUiHostTestCases". It no longer fails. Review-Url: https://codereview.chromium.org/2855883009 Cr-Commit-Position: refs/heads/master@{#469823} (cherry picked from commit 67679038561e87a38508710c0058477333b40eac) Review-Url: https://codereview.chromium.org/2871443002 . Cr-Commit-Position: refs/branch-heads/3071@{#441} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/77c20f176331e7e12d466b559d0af6d204676fd8/components/exo/wayland/server.cc
,
May 24 2017
,
Jan 22 2018
,
Feb 26 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by osh...@chromium.org
, May 4 2017