New issue
Advanced search Search tips

Issue 718394 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue v8:6127


Participants' hotlists:
Hotlist-AsmJsParser


Sign in to add a comment

V8 switching from AST-based to dedicated asm.js validator

Project Member Reported by mstarzinger@chromium.org, May 4 2017

Issue description

V8 is switching the underlying validator used for --validate-asm (i.e. the feature enabled in Chrome via --enable-features=AsmJsToWebAssembly). This will change the content of some validation warnings and hence require a rebaseline of some layout tests. Note that only the textual content of the warnings changes, not where and when these warnings appear.

Related V8 tracking bug:  issue v8:6127 
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13da7bbd393358ca25773407d2139980b2002133

commit 13da7bbd393358ca25773407d2139980b2002133
Author: mstarzinger <mstarzinger@chromium.org>
Date: Thu May 04 12:27:39 2017

[v8] Mark layout tests for rebaseline.

The tests in question need to be rebaselined after V8 has been rolled
with the new asm.js validator enabled. This feature is not yet enabled.

R=machenbach@chromium.org
BUG= chromium:718394 
NOTRY=true

Review-Url: https://codereview.chromium.org/2860073002
Cr-Commit-Position: refs/heads/master@{#469315}

[modify] https://crrev.com/13da7bbd393358ca25773407d2139980b2002133/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a0e41a86180a90bb523c9ae3b577b223f31aa87

commit 1a0e41a86180a90bb523c9ae3b577b223f31aa87
Author: mstarzinger <mstarzinger@chromium.org>
Date: Tue May 09 11:56:19 2017

[v8] Mark layout tests for automatic rebaseline.

Now that a V8 version with the new asm.js validator has been rolled into
Chromium, the affected layout tests can be automatically rebased. This
feature is not yet enabled.

R=machenbach@chromium.org
BUG= chromium:718394 
NOTRY=true

Review-Url: https://codereview.chromium.org/2865113006
Cr-Commit-Position: refs/heads/master@{#470286}

[modify] https://crrev.com/1a0e41a86180a90bb523c9ae3b577b223f31aa87/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2017

Project Member

Comment 5 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30e66e1ff63c37aa4d3e2d1cde170ad95800f2be

commit 30e66e1ff63c37aa4d3e2d1cde170ad95800f2be
Author: mstarzinger <mstarzinger@chromium.org>
Date: Mon May 15 12:53:33 2017

[v8] Manually rebaseline asm.js layout tests.

Now that a V8 version with the new asm.js validator has been rolled into
Chromium, the affected layout tests can be rebased. This feature is not
yet enabled.

R=machenbach@chromium.org
BUG= chromium:718394 

Review-Url: https://codereview.chromium.org/2882203002
Cr-Commit-Position: refs/heads/master@{#471740}

[modify] https://crrev.com/30e66e1ff63c37aa4d3e2d1cde170ad95800f2be/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/30e66e1ff63c37aa4d3e2d1cde170ad95800f2be/third_party/WebKit/LayoutTests/virtual/enable_asmjs/http/tests/asmjs/asm-warnings-expected.txt

Status: Fixed (was: Assigned)
Everything done here.

Sign in to add a comment