Issue metadata
Sign in to add a comment
|
Regression: 'Prefer this network' and 'Automatically connect to this network' options are getting disabled automatically in network details page of chrome://md-settings. |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3086.0/9520.0.0 dev-channel Daisy,Candy,Minnie OS:Chrome OS What steps will reproduce the problem? (1)Sign in to chrome >> Navigate to chrome://md-settings/networks?type=WiFi page (2)Click on connected WiFi network such that network details page is seen (3)Enable 'Prefer this network' and 'Automatically connect to this network' options and click on back arrow (4)Now Observe 'Prefer this network' and 'Automatically connect to this network' options by navigating back to network details page. (Please refer video) Expected: 'Prefer this network' and 'Automatically connect to this network' options shouldn't disable automatically when clicked on back arrow and navigating back to network details page. Actual: Instead,'Prefer this network' and 'Automatically connect to this network' options are getting disabled automatically This is regression issue as it is working fine in M57. Attaching screen-cast for reference.
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b59f96b265d0bfb15ee56647ab4e3e28ae886b38 commit b59f96b265d0bfb15ee56647ab4e3e28ae886b38 Author: stevenjb <stevenjb@chromium.org> Date: Thu May 04 23:39:14 2017 MD Settings: Network: Do not call setProperties when setting defaults In https://codereview.chromium.org/2665913002 we set some default network properties in currentRouteChanged. This was triggering networkPropertiesChanged_ which udates autoConnect_ and preferNetwork_ which triggers calls to setNetworkProperties. To prevent this sort of error, set networkPropertiesReceived_ once properties are received from Chrome and do not call networkingPrivate.setProperties until that has been set. BUG= 718389 Review-Url: https://codereview.chromium.org/2863713004 Cr-Commit-Position: refs/heads/master@{#469523} [modify] https://crrev.com/b59f96b265d0bfb15ee56647ab4e3e28ae886b38/chrome/browser/resources/settings/internet_page/internet_detail_page.js
,
May 4 2017
,
May 5 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5bf61790cc99348dd4589cfc032c8a0133d3d50 commit c5bf61790cc99348dd4589cfc032c8a0133d3d50 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon May 08 16:31:28 2017 MD Settings: Network: Do not call setProperties when setting defaults In https://codereview.chromium.org/2665913002 we set some default network properties in currentRouteChanged. This was triggering networkPropertiesChanged_ which udates autoConnect_ and preferNetwork_ which triggers calls to setNetworkProperties. To prevent this sort of error, set networkPropertiesReceived_ once properties are received from Chrome and do not call networkingPrivate.setProperties until that has been set. BUG= 718389 Review-Url: https://codereview.chromium.org/2863713004 Cr-Commit-Position: refs/heads/master@{#469523} (cherry picked from commit b59f96b265d0bfb15ee56647ab4e3e28ae886b38) Review-Url: https://codereview.chromium.org/2871523003 . Cr-Commit-Position: refs/branch-heads/3071@{#447} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/c5bf61790cc99348dd4589cfc032c8a0133d3d50/chrome/browser/resources/settings/internet_page/internet_detail_page.js
,
May 12 2017
,
May 15 2017
Verified on ChromeOS 9460.40.0, 59.0.3071.49 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, May 4 2017Status: Started (was: Assigned)