New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 718361 link

Starred by 1 user
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: May 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Glimpse of loader icon is seen after entering/deleting text from search field in chrome://history

Reported by vku...@etouch.net, May 4 2017 
Chrome Version: 60.0.3088.3 (Official Build)  49d525d4dafb21903d1cd21025174928a3fdde75-refs/branch-heads/3088@{#4} (32/64 bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://history/
(2)Type any text for e.g 'testing' in search field and observe search icon 
(3)Hit backspace key to clear data,observe the icon

Actual: Glimpse of loader icon is seen after entering/deleting text from search field.

Expected: No such glimpse of loader icon should be seen after entering/deleting text from search field.

This is a regression issue broken in 'M55' and below is the manual regression range
Good Build: 55.0.2851.0 
Bad Build:  55.0.2853.0
Actual_History.mov
1.3 MB Download
Expected_History.mov
1.3 MB Download

Comment 1 by sandeepkumars@chromium.org, May 4 2017

Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build: 55.0.2851.0 (Revision: 416559 )
Bad Build:  55.0.2853.0  (Revision: 416812 )

You are probably looking for a change made after 416603 (known good), but no later than 416604 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/5e1f45d8c5fff4a1e635616bace6ce4f6ec3aa78..9844d8891a6c83304ba67ca07e55b7c658e958e9

@tsergeant: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review URL:  https://codereview.chromium.org/2311093002

Thank You.

Comment 2 by tsergeant@chromium.org, May 5 2017

Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)
Can reproduce, and I have a fix. This is a pretty small visual issue, though, so reducing the priority.

Comment 3 by sandeepkumars@chromium.org, May 5 2017

Labels: hasbisect-per-revision
Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d1496a99b064d43adbee156731a2b895ced6d39

commit 7d1496a99b064d43adbee156731a2b895ced6d39
Author: tsergeant <tsergeant@chromium.org>
Date: Mon May 08 09:19:42 2017

MD WebUI: Reduce flickering of spinner in toolbar search field

In https://crrev.com/402922, the loading spinner inside the WebUI
toolbar search field was changed to gradually fade in and out, reducing
flickering when the spinner was only shown for a short amount of time.

However, https://crrev.com/416604 regressed this behavior by wrapping the
spinner in a dom-if, improving performance but preventing the fade
animation.

This CL combines both approaches, using a dom-if to lazily render the
spinner the first time it is used, but then using the fade animation to
show and hide the spinner thereafter.

BUG= 718361 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2861093002
Cr-Commit-Position: refs/heads/master@{#469935}

[modify] https://crrev.com/7d1496a99b064d43adbee156731a2b895ced6d39/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
[modify] https://crrev.com/7d1496a99b064d43adbee156731a2b895ced6d39/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js

Comment 5 by msrchandra@chromium.org, May 11 2017

Labels: TE-Verified-60.0.3095.5 TE-Verified-M60
Tested the issue on Latest Dev# 60.0.3095.5 on Windows, Mac and Linux and found the issue to be Fixed.
Hence adding TE-Verified Labels.
Adding screen cast for future reference.
Thank You.
718361.ogv
489 KB View Download

Comment 6 by tsergeant@chromium.org, May 15 2017

Status: Fixed (was: Started)
►

Sign in to add a comment