HatsNotificationControllerTest unit_tests fail on my linux workstation. |
|||||
Issue description
HatsNotificationControllerTest unit_tests fail on my linux workstation.
These unit_tests frequently/always fail, most others don't. Please help take a look, thanks!
HatsNotificationControllerTest.DismissNotification_ShouldUpdatePref
HatsNotificationControllerTest.NewDevice_ShouldNotShowNotification
HatsNotificationControllerTest.NoInternet_DoNotShowNotification
HatsNotificationControllerTest.OldDevice_ShouldShowNotification
Here is my command line, gn args below: unit_tests --ozone-platform="headless"
is_component_build = true
target_os = "chromeos"
use_goma = true
use_ozone = true
ozone_auto_platforms = false
ozone_platform_headless = true
ozone_platform_x11 = true
ozone_platform = "x11"
Here is output from one of the failed test runs, not very enlightening:
$ unit_tests --ozone-platform="headless" --gtest_filter=HatsNotificationControllerTest.DismissNotification_ShouldUpdatePref
[ RUN ] HatsNotificationControllerTest.DismissNotification_ShouldUpdatePref
unknown file: Failure
Uninteresting mock function call - returning directly.
Function call: AddAndFireObserver(0x2e39f088f398)
[ FAILED ] HatsNotificationControllerTest.DismissNotification_ShouldUpdatePref (582 ms)
I don't see a Hats crbug component, should there be one or what should I use?
,
May 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a013b9f13e9f574eeeadff3f4067aa7999ab0d2f commit a013b9f13e9f574eeeadff3f4067aa7999ab0d2f Author: malaykeshav <malaykeshav@chromium.org> Date: Tue May 09 04:13:24 2017 Add EXPECT_CALL to fix warning during unit_test run for Hats Adds EXPECT_CALL to HatsNotification Controller test to fix warnings. BUG=718350 COMPONENT=HaTS, Chrome OS Review-Url: https://codereview.chromium.org/2866133002 Cr-Commit-Position: refs/heads/master@{#470189} [modify] https://crrev.com/a013b9f13e9f574eeeadff3f4067aa7999ab0d2f/chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc
,
May 9 2017
,
May 25 2017
Reopening; these still fail with the steps from my initial report. Please take another look and let me know if you need help with repro.
,
Sep 7 2017
These fail for me too when running xvfb-run out/Default/unit_tests.
,
Sep 7 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by malaykeshav@chromium.org
, May 8 2017