Issue metadata
Sign in to add a comment
|
Relaunch Label is misplaced under chrome://md-settings/help |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3088.3 OS: Windows 7 / 8.1 / 10 (32 & 64 - bit PGO) What steps will reproduce the problem? (1) Install 60.0.3088.0_chrome_installer_w3p.exe via cmd and launch. (2) Navigate to chrome://md-settings/help (3) Now via cmd install 60.0.3088.3_60.0.3088.0_chrome_updater_w3p.exe. (4) After executing the command successfully refresh chrome://md-settings/help and observe. What is the expected result? Relaunch label should be aligned properly. What happens instead? In Windows 7, relaunch label is misaligned. In Windows 8.1 & 10, relaunch label is misaligned and unwanted line is displayed. Below is the CL between 60.0.3080.5 and 60.0.3088.3 -- https://chromium.googlesource.com/chromium/src/+log/60.0.3080.0..60.0.3088.0?pretty=fuller&n=10000 Attached screenshots for reference. Unable to find the exact suspect from the above CL. Could some one from material design team please look into the issue and provide an update. Thank You.
,
May 4 2017
,
May 4 2017
It could be either https://codereview.chromium.org/2849663002 or https://codereview.chromium.org/2848443002 I'll take a look and re-assign accordingly.
,
May 4 2017
,
May 4 2017
Assigning to dschuyler@. I verified that https://codereview.chromium.org/2849663002 is the culprit. To reproduce easily, go to chrome://md-settings/help, locate settings-about-page in the dev tools, and then execute the following in the console $0.onUpdateStatusChanged_({status: UpdateStatus.NEARLY_UPDATED, message: 'foo'})
,
May 4 2017
yooooink https://codereview.chromium.org/2862963002
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99f1e6d53a28086375ee80a5907fbc260da0d8da commit 99f1e6d53a28086375ee80a5907fbc260da0d8da Author: dbeam <dbeam@chromium.org> Date: Thu May 04 22:45:28 2017 MD Settings/Help: re-arrange separator DOM on about page R=dschuyler@chromium.org BUG= 718345 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2862963002 Cr-Commit-Position: refs/heads/master@{#469494} [modify] https://crrev.com/99f1e6d53a28086375ee80a5907fbc260da0d8da/chrome/browser/resources/settings/about_page/about_page.html
,
May 4 2017
,
May 11 2017
Tested the issue using Chrome Dev# 60.0.3095.5 on Windows 7 / 8.1 / 10 and found the issue to be fixed. Relaunch label is aligned properly. Hence adding TE-Verified labels. Thank You. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, May 4 2017