Change a small number of DVLOGs in VDAs/VEAs/JDAs/V4L2IP to VLOGs |
||||||
Issue descriptionThis is branched from http://crbug.com/697733 . We should change some important logs like VDA::Initalize to VLOG. Otherwise, we cannot find anything useful in the chrome log and have to manually reproduce every time someone files a bug.
,
May 23 2017
,
Jun 6 2017
Changes for v4l2_vda is in review: https://codereview.chromium.org/2896193002/
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ff2c4bb232deb1cc6aed58aa74996d81d34e098 commit 7ff2c4bb232deb1cc6aed58aa74996d81d34e098 Author: owenlin <owenlin@chromium.org> Date: Wed Jun 14 05:06:09 2017 v4l2_vda: Adjust the DVLOG levels. We are going to enabling the log in our testing. First step is to make sure the verbose level meets out expectation. Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=build on veyron_minnie. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2896193002 Cr-Commit-Position: refs/heads/master@{#479290} [modify] https://crrev.com/7ff2c4bb232deb1cc6aed58aa74996d81d34e098/media/gpu/v4l2_video_decode_accelerator.cc
,
Jun 22 2017
I started to se the logs in the test failures. Super useful! Owen. Can you continue to do other files? Also please help remove this VLOG. It's printed too many times. 06/21 15:24:22.328 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268612:1995616346:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=1 06/21 15:24:22.334 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268621:1995616355:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=2 06/21 15:24:22.340 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268629:1995616363:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=3 06/21 15:24:22.346 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268643:1995616377:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=4 06/21 15:24:22.352 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268649:1995616383:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=5 06/21 15:24:22.358 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268655:1995616390:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=6 06/21 15:24:22.363 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268662:1995616396:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=7 06/21 15:24:22.369 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268668:1995616403:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=8 06/21 15:24:22.376 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268674:1995616409:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=9 06/21 15:24:22.382 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268682:1995616417:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=10 06/21 15:24:22.388 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268689:1995616423:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=11 06/21 15:24:22.393 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268695:1995616429:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=12 06/21 15:24:22.396 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268701:1995616435:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=13 06/21 15:24:22.399 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268707:1995616442:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=14 06/21 15:24:22.402 ERROR| utils:0280| [stderr] [2444:2748:0621/152422.268714:1995616448:VERBOSE2:v4l2_video_decode_accelerator.cc(2532)] DestroyOutputBuffers(): dismissing PictureBuffer id=15
,
Jun 22 2017
The log is a lot. Let's remove two more. Let's also remove VLOG in line 1315. Line 1323 is enough. 06/21 15:24:31.248 ERROR| utils:0280| [stderr] [2444:3015:0621/152431.181955:2004529692:VERBOSE2:v4l2_video_decode_accelerator.cc(1315)] DequeueResolutionChangeEvent(): 06/21 15:24:31.253 ERROR| utils:0280| [stderr] [2444:3015:0621/152431.181982:2004529717:VERBOSE2:v4l2_video_decode_accelerator.cc(1323)] DequeueResolutionChangeEvent(): got resolution change event. This doesn't look very useful. 06/21 15:24:26.585 ERROR| utils:0280| [stderr] [2444:2890:0621/152426.541645:1999889383:VERBOSE2:v4l2_video_decode_accelerator.cc(1685)] IsDecoderCmdSupported(): V4L2_DEC_CMD_STOP is not supported.
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96e54d19b5ae6d0609dc2f31f8bd5267fbd16895 commit 96e54d19b5ae6d0609dc2f31f8bd5267fbd16895 Author: Owen Lin <owenlin@google.com> Date: Tue Jun 27 03:19:35 2017 v4l2_vda: Change some verbose debug messages from VLOG(2) to DVLOG(3). BUG= chromium:718334 TEST=None. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I868484b2dda16d5de2a43ba0e3908f7bbfd37180 Reviewed-on: https://chromium-review.googlesource.com/544643 Reviewed-by: Wu-cheng Li <wuchengli@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Commit-Queue: Owen Lin <owenlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#482527} [modify] https://crrev.com/96e54d19b5ae6d0609dc2f31f8bd5267fbd16895/media/gpu/v4l2_video_decode_accelerator.cc
,
Jul 20 2017
Changes for v4l2_svda is in review: https://chromium-review.googlesource.com/c/578760/
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e88fb5db91a711a939dada37ef6f207da7ce13af commit e88fb5db91a711a939dada37ef6f207da7ce13af Author: Hirokazu Honda <hiroh@chromium.org> Date: Thu Aug 31 06:56:44 2017 vaapi_vda: Adjust the (D)VLOG levels and change some DVLOGs to VLOGs and LOG(ERROR) to VLOG(1) Adjust verbose log levels and change LOG(ERROR) to VLOG(1) to obtain useful information for testing. Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=VDA unittest on an intel device Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I014a3481ac8ba2d4a9753fb11df6f8c804be064c Reviewed-on: https://chromium-review.googlesource.com/642156 Reviewed-by: Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#498771} [modify] https://crrev.com/e88fb5db91a711a939dada37ef6f207da7ce13af/media/gpu/vaapi_video_decode_accelerator.cc
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30abf4915e8e5f6362474c9126d23bce0b606053 commit 30abf4915e8e5f6362474c9126d23bce0b606053 Author: Hirokazu Honda <hiroh@chromium.org> Date: Thu Aug 31 07:33:37 2017 v4l2_svda: Adjust the (D)VLOG levels, and change some DVLOG to VLOG and LOG(ERROR) to VLOG(1) Adjust verbose log levels and change LOG(ERROR) to VLOG(1) to obtain useful information for testing. Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=VDA unittest on kevin Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5ea51cf8f8b1ea3ea3a3b554910f2a368b46c2f3 Reviewed-on: https://chromium-review.googlesource.com/578760 Reviewed-by: Pawel Osciak <posciak@chromium.org> Reviewed-by: Owen Lin <owenlin@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#498778} [modify] https://crrev.com/30abf4915e8e5f6362474c9126d23bce0b606053/media/gpu/v4l2_slice_video_decode_accelerator.cc
,
Sep 6 2017
Assign to Hiro, since he is actively working on this.
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b61a27f4912ede93c725dc0597cfcbdbf321606 commit 0b61a27f4912ede93c725dc0597cfcbdbf321606 Author: Hirokazu Honda <hiroh@chromium.org> Date: Fri Sep 08 04:15:47 2017 vaapi_vea: Adjust the (D)VLOG levels, and change some DVLOGs to VLOGs and LOG(ERROR) to VLOG(1) Adjust verbose log levels and change some VLOGs to somne VLOGs and LOG(ERROR) to VLOG(1), to obtain useful information for testing. Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=VDA unittest on an intel device Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie5f6633c5f52e6137af3006083e6226752f54c64 Reviewed-on: https://chromium-review.googlesource.com/644654 Reviewed-by: Owen Lin <owenlin@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#500503} [modify] https://crrev.com/0b61a27f4912ede93c725dc0597cfcbdbf321606/media/gpu/vaapi_video_encode_accelerator.cc
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3450b8d8ad8d41fee948d46d00cc38331af26d5a commit 3450b8d8ad8d41fee948d46d00cc38331af26d5a Author: Hirokazu Honda <hiroh@chromium.org> Date: Fri Sep 08 04:15:53 2017 vaapi_jda: Adjust the (D)VLOG levels, and change some DVLOG to VLOG and LOG(ERROR) to VLOG(1) Adjust verbose log levels and change some VLOGs to somne VLOGs and LOG(ERROR) to VLOG(1), to obtain useful information for testing. Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=JDA unittest on an intel device Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I61c288846cfd9fe567c3f00c8512c8183cfcd053 Reviewed-on: https://chromium-review.googlesource.com/644593 Reviewed-by: Owen Lin <owenlin@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#500504} [modify] https://crrev.com/3450b8d8ad8d41fee948d46d00cc38331af26d5a/media/gpu/vaapi_jpeg_decode_accelerator.cc
,
Sep 9 2017
I uploaded CLs for v4l2_vea and v4l2_jda. crrev.com/c/658200, crrev.com/c/657521 I noticed that v4l2_device output much log when V4L2VEA unittest with DEBUG build was run. So I will improve it and v4l2 image processor after the v4l2_vea and v4l2_jda will be merged. Perhaps I should also improve v4l2_vda, because some log change rule has been changed since it was changed.
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34fe3366c53989dcd778e761e42b2f21b351c64c commit 34fe3366c53989dcd778e761e42b2f21b351c64c Author: Hirokazu Honda <hiroh@chromium.org> Date: Mon Oct 02 08:02:11 2017 v4l2_ip: Adjust the (D)VLOG levels and change some DVLOGs to VLOGs and LOG(ERROR) to VLOG(1) Adjust verbose log levels and change LOG(ERROR) to VLOG(1) to obtain useful information for testing. Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=VDA unittest on elm and VEA unittest on peach_pit Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icaa2c4acf1bee1f3c76cc5f5360b3f6ea1e83b2e Reviewed-on: https://chromium-review.googlesource.com/688775 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#505557} [modify] https://crrev.com/34fe3366c53989dcd778e761e42b2f21b351c64c/media/gpu/v4l2_image_processor.cc
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcec9c6d650fc41f56fb98a4f8f957915ba1d34d commit dcec9c6d650fc41f56fb98a4f8f957915ba1d34d Author: Hirokazu Honda <hiroh@chromium.org> Date: Thu Dec 21 04:26:55 2017 v4l2_jda: Adjust the (D)VLOG levels and change some DVLOGs to VLOGs and LOG(ERROR) to VLOG(1) Adjust verbose log levels and change LOG(ERROR) to VLOG(1) to obtain useful information for testing. Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=JDA unittest on peach_pit Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ieb5db24186bd8bc76914866bf889cd6f5894d8ac Reviewed-on: https://chromium-review.googlesource.com/657521 Reviewed-by: Pawel Osciak <posciak@chromium.org> Reviewed-by: Owen Lin <owenlin@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#525602} [modify] https://crrev.com/dcec9c6d650fc41f56fb98a4f8f957915ba1d34d/media/gpu/v4l2/v4l2_jpeg_decode_accelerator.cc
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50503cc31dc6440cab0495fbfd013fd5fb3a7ae1 commit 50503cc31dc6440cab0495fbfd013fd5fb3a7ae1 Author: Hirokazu Honda <hiroh@chromium.org> Date: Thu Dec 21 05:38:25 2017 v4l2_vea: Adjust the (D)VLOG levels and change some DVLOGs to VLOGs and LOG(ERROR) to VLOG(1) Adjust verbose log levels and change LOG(ERROR) to VLOG(1) to obtain useful information for testing. Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=VEA unittest on peach_pit Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If3e8d78bf5aec8855a8ca5f3ba3fd7cc30fc0520 Reviewed-on: https://chromium-review.googlesource.com/658200 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Reviewed-by: Owen Lin <owenlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#525623} [modify] https://crrev.com/50503cc31dc6440cab0495fbfd013fd5fb3a7ae1/media/gpu/v4l2/v4l2_video_encode_accelerator.cc
,
Dec 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09ea0d26ff55919ab8af25438d9704c8c6fad2ad commit 09ea0d26ff55919ab8af25438d9704c8c6fad2ad Author: Hirokazu Honda <hiroh@chromium.org> Date: Tue Dec 26 04:55:08 2017 v4l2_device: Adjust the (D)VLOG levels and change some DVLOGs to VLOGs and LOG(ERROR) to VLOG(1) Adjust verbose log levels and change LOG(ERROR) to VLOG(1) in v4l2_device, generic_v4l2_device and tegra_v4l2_device, to obtain useful information for testing. Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=VDA and VEA unittest on peach_pit and nyan_big Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic7fdd7c3e0d7510e40224a7c7ffed74705bded67 Reviewed-on: https://chromium-review.googlesource.com/688782 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#526186} [modify] https://crrev.com/09ea0d26ff55919ab8af25438d9704c8c6fad2ad/media/gpu/v4l2/generic_v4l2_device.cc [modify] https://crrev.com/09ea0d26ff55919ab8af25438d9704c8c6fad2ad/media/gpu/v4l2/tegra_v4l2_device.cc [modify] https://crrev.com/09ea0d26ff55919ab8af25438d9704c8c6fad2ad/media/gpu/v4l2/v4l2_device.cc
,
Dec 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/533b299c8b27b6f00387f2c3dfb018c175868271 commit 533b299c8b27b6f00387f2c3dfb018c175868271 Author: Hirokazu Honda <hiroh@chromium.org> Date: Tue Dec 26 08:07:17 2017 v4l2_vda: Adjust the (D)VLOG levels and change some DVLOGs to VLOGs and LOG(ERROR) to VLOG(1) Adjust verbose log levels and change LOG(ERROR) to VLOG(1) in v4l2_vda, Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=VDA unittest on peach_pit Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I686d09f2cda606574748ce2d757394a3df366e32 Reviewed-on: https://chromium-review.googlesource.com/844013 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#526188} [modify] https://crrev.com/533b299c8b27b6f00387f2c3dfb018c175868271/media/gpu/v4l2/v4l2_video_decode_accelerator.cc
,
Jan 3 2018
hiroh@, the component OS>Kernel seems insufficient for this issue, since it does not (only) apply to the kernel nor the OS, instead shouldn't it perhaps include/be under Internals>GPU>... ?
,
Jan 9 2018
OS>Kernel>Video is a standard tag used in ChromeOS video team. It is used for issues regardless which is related to kernel. Yes. This is confusing. However, we have no other good tag for our team currently. On the one hand, the description of "OS>Kernel>Video" is "platform video". It doesn't state that it is limited to kernel issues. Perhaps, it's better to create a new tag like OS>Platform>Video, and use it for all the video issues on ChromeOS. By the way, this CL will be closed soon after crrev.com/c/844403 will be merged.
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c41641e97677259c023ef31d1009fd757a0fd5dd commit c41641e97677259c023ef31d1009fd757a0fd5dd Author: Hirokazu Honda <hiroh@chromium.org> Date: Tue Jan 09 10:17:42 2018 vaapi_jea: Add DVLOGs and LOGs and change LOG(ERROR) to VLOG(1) Add verbose logs and change LOG(ERROR) to VLOG(1) in vaapi_jea, Basically, we use 1 for errors. 2 for things like initialization, change of resolution, reset, etc. 4 was per frame info. 3 everything between 2 and 4. BUG= chromium:718334 TEST=JEA unittest on caroline Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icfc8ab449f49ce09a250ebe08d80a99abf83c000 Reviewed-on: https://chromium-review.googlesource.com/844403 Reviewed-by: Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#527950} [modify] https://crrev.com/c41641e97677259c023ef31d1009fd757a0fd5dd/media/gpu/vaapi/vaapi_jpeg_encode_accelerator.cc
,
Jan 9 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by owenlin@chromium.org
, May 18 2017