Android: FaceDetector.detect() needs an image whose width is even |
||||||
Issue descriptionAfter some time, I don’t get any faces from faceDetector.detect(). See my adb logs below. It looks like the image width needs to be even according to http://stackoverflow.com/questions/13360322/return-0-faces-because-error-exists-btk-facefinder-putdcr-error-in-android-fac and https://developer.android.com/reference/android/media/FaceDetector.html ERROR: Return 0 faces because error exists in btk_FaceFinder_putDCR. It would be nice if the Shape Detection API would handle this by itself so that web developers don't have to suffer from it.
,
May 30 2017
,
Jun 5 2017
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a0467d09ee04895790ebc65034a3537aeb97efd commit 3a0467d09ee04895790ebc65034a3537aeb97efd Author: Conley Owens <cco3@chromium.org> Date: Thu Jun 08 20:47:24 2017 Add instrumentation tests for face detection Currently Android face detection has no tests. This change rectifies that situation. These are instrumentation test rather than junit tests because face detection doesn't actually return any results in junit. The tests are registered to run as part of chrome_test_java. These are run on the linux_android_rel_ng trybots. BUG= 718329 , 722931 Change-Id: I512aa4391f6910c7992781fb59cb9cd0bbd5fe58 Reviewed-on: https://chromium-review.googlesource.com/523013 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#478078} [modify] https://crrev.com/3a0467d09ee04895790ebc65034a3537aeb97efd/chrome/android/BUILD.gn [modify] https://crrev.com/3a0467d09ee04895790ebc65034a3537aeb97efd/services/BUILD.gn [add] https://crrev.com/3a0467d09ee04895790ebc65034a3537aeb97efd/services/shape_detection/android/javatests/src/org/chromium/shape_detection/FaceDetectionImplTest.java [modify] https://crrev.com/3a0467d09ee04895790ebc65034a3537aeb97efd/services/shape_detection/face_detection_impl_mac_unittest.mm [add] https://crrev.com/3a0467d09ee04895790ebc65034a3537aeb97efd/services/test/data/mona_lisa.jpg
,
Jun 8 2017
,
Jun 8 2017
Still need your +1 on this: https://chromium-review.googlesource.com/c/520102/11
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bcfd9d50099d3dc33b66b50b9fdfcf099248298 commit 5bcfd9d50099d3dc33b66b50b9fdfcf099248298 Author: Conley Owens <cco3@chromium.org> Date: Fri Jun 09 20:53:23 2017 Face detect with odd image widths on Android Android requires an even width to do face detection. This change pads the image before handing it to the Android API. BUG= 718329 Change-Id: I512aa4391f6910c7992781fb59cb9cd0bbd5fe59 Reviewed-on: https://chromium-review.googlesource.com/520102 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#478408} [modify] https://crrev.com/5bcfd9d50099d3dc33b66b50b9fdfcf099248298/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java [modify] https://crrev.com/5bcfd9d50099d3dc33b66b50b9fdfcf099248298/services/shape_detection/android/javatests/src/org/chromium/shape_detection/FaceDetectionImplTest.java
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bcfd9d50099d3dc33b66b50b9fdfcf099248298 commit 5bcfd9d50099d3dc33b66b50b9fdfcf099248298 Author: Conley Owens <cco3@chromium.org> Date: Fri Jun 09 20:53:23 2017 Face detect with odd image widths on Android Android requires an even width to do face detection. This change pads the image before handing it to the Android API. BUG= 718329 Change-Id: I512aa4391f6910c7992781fb59cb9cd0bbd5fe59 Reviewed-on: https://chromium-review.googlesource.com/520102 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#478408} [modify] https://crrev.com/5bcfd9d50099d3dc33b66b50b9fdfcf099248298/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java [modify] https://crrev.com/5bcfd9d50099d3dc33b66b50b9fdfcf099248298/services/shape_detection/android/javatests/src/org/chromium/shape_detection/FaceDetectionImplTest.java
,
Jun 9 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mcasas@chromium.org
, May 17 2017