New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 718318 link

Starred by 2 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'SIGN IN TO CHROME' button is not seen properly under 'People' section.

Reported by dchau...@etouch.net, May 4 2017 
Chrome Version: 60.0.3088.3 (Official Build) canary (64-bit)49d525d4dafb21903d1cd21025174928a3fdde75-refs/branch-heads/3088@{#4} 32/64-bit.
OS: Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings page.
2. Click on profile icon under 'People' section to open 'Edit person' page.
3. Enter long name in textbox and go to chrome://settings page.
4. Now, observe the 'SIGN IN TO CHROME' button under 'People' section.

'SIGN IN TO CHROME' button is not seen properly.
'SIGN IN TO CHROME' button should seen properly.

This is a regression issue, broken in M-60 series, will soon update other info.

Comment 1 by dchau...@etouch.net, May 4 2017

Labels: OS-Linux OS-Mac
Below is manual regression range.

Good build: 60.0.3086.0
Bad build: 60.0.3087.0

Kindly review the attached screen-cast for reference.
Buttons_Screenshot.png
31.5 KB View Download
Actual behavior.mp4
633 KB View Download
Expected behavior.mp4
561 KB View Download

Comment 2 by sandeepkumars@chromium.org, May 4 2017

Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 60.0.3086.0 (Revision:468266)
Bad build: 60.0.3087.0 (Revision:468507)

You are probably looking for a change made after 468470 (known good), but no later than 468471 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/dc843fac8da1a46453dd6035c910c07f5237922c..898ae07dedccc8e9a9a125c662ce1c28af55d41f

@dschuyler: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review URL: https://codereview.chromium.org/2847583002

Thank You.

Comment 3 by dschuyler@chromium.org, May 4 2017

Status: Started (was: Assigned)
CL at https://codereview.chromium.org/2864483006/
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d06f045c53f2f42420e6ca4d57d3c608f529c9c

commit 8d06f045c53f2f42420e6ca4d57d3c608f529c9c
Author: dschuyler <dschuyler@chromium.org>
Date: Thu May 04 22:55:11 2017

[MD settings] prevent paper-buttons from shrinking

This CL prevents flex pressure from squeezing paper-buttons. E.g. prevent
a long account name from making the "sign in to chrome" button into a
column of text.

BUG= 718318 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2864483006
Cr-Commit-Position: refs/heads/master@{#469502}

[modify] https://crrev.com/8d06f045c53f2f42420e6ca4d57d3c608f529c9c/chrome/browser/resources/settings/settings_shared_css.html

Comment 5 by dschuyler@chromium.org, May 4 2017

Status: Fixed (was: Started)

Comment 6 by msrchandra@chromium.org, May 11 2017

Labels: TE-Verified-60.0.3095.5 TE-Verified-M60
Tested the issue on Latest Dev# 60.0.3095.5 on Windows, Mac and Linux and found the issue to be Fixed.
Hence adding TE-Verified Labels.
Adding screen cast for future reference.
Thank You.
718318.ogv
1.4 MB View Download
►

Sign in to add a comment