Improve JumpList icon folders' naming style |
||
Issue descriptionCurrently, the JumpList class has a data member icon_dir_ to hold /profile_dir/kJumpListIconDirname, which indicates that there's only one directory to hold jumplist icons. However, there are actually more than one icon directory. When generating these directory names, we append various kFoos to icon_dir_. This is confusing and we should find a better way to generate these folder names.
,
May 5 2017
It seems that the closed CL where this bug is attached doesn't show up here. So I'll manually paste the information of that CL in the next comment.
,
May 5 2017
Author: chengx <chengx@chromium.org> Improve JumpList icon folders' naming style Currently, the JumpList class has a data member icon_dir_ to hold /profile/kJumpListIconDirname, which indicates that there's only one directory to hold jumplist icons. However, there are actually more than one icon directory. When generating these directory names, we append various kFoos to icon_dir_. It's better to append (chrome::kJumpListIconDirname + kFoo) as a whole to the profile directory as needed at the various points of use, rather than the current adding various kFoos to icon_dir_. This avoids the confusion. BUG= 718314 Review-Url: https://codereview.chromium.org/2846383002 Cr-Commit-Position: refs/heads/master@{#469431} Committed: https://chromium.googlesource.com/chromium/src/+/6dbff02c181d5689f8c509b0890733c5c7b9a413
,
May 5 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by chengx@chromium.org
, May 4 2017Components: Internals>PlatformIntegration
Labels: OS-Windows