Issue 718258 link

Starred by 0 users

Issue metadata

Status:	Fixed
Owner:	vapier@chromium.org
Closed:	May 2017
Components:	Platform>Apps>Default>Hterm
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Feature

nassh: add IDNA support

Project Member Reported by vapier@chromium.org, May 4 2017

Issue description

today if you try to use an IDN, it fails.  we end up just trying to connect to a hostname using the encoded bytes.

for example, 日本.com will try \346\227\245\346\234\254.com when it should have used punycode to connect to xn--wgv71a.example.com.

seems like we should be able to import this guy:
https://github.com/bestiejs/punycode.js

license is MIT

Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/76328fed579cf360b0f95926ea9035f6c52c5887

commit 76328fed579cf360b0f95926ea9035f6c52c5887
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue May 09 17:59:01 2017

libdot: integrate punycode.js

Use the JS implementation of the punycode algorithm that much of
community does.  This is the canonical implementation in the NPM
and node.js world.

BUG= chromium:718258 

Change-Id: Ia28032c7e34bd2b378a362c2f49d4bfb8a03201d
Reviewed-on: https://chromium-review.googlesource.com/495353
Reviewed-by: Rob Ginda <rginda@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/76328fed579cf360b0f95926ea9035f6c52c5887/libdot/third_party/punycode/LICENSE.md
[modify] https://crrev.com/76328fed579cf360b0f95926ea9035f6c52c5887/libdot/html/lib_test.html
[add] https://crrev.com/76328fed579cf360b0f95926ea9035f6c52c5887/libdot/third_party/punycode/lib_punycode.js
[add] https://crrev.com/76328fed579cf360b0f95926ea9035f6c52c5887/libdot/third_party/punycode/METADATA
[add] https://crrev.com/76328fed579cf360b0f95926ea9035f6c52c5887/libdot/third_party/punycode/lib_punycode_tests.js
[add] https://crrev.com/76328fed579cf360b0f95926ea9035f6c52c5887/libdot/third_party/punycode/update
[add] https://crrev.com/76328fed579cf360b0f95926ea9035f6c52c5887/libdot/third_party/punycode/README.md

Comment 2 by vapier@chromium.org, May 10 2017

Owner: vapier@chromium.org
Status: Fixed (was: Available)

forgot to link to this bug in the last CL:
  https://chromium-review.googlesource.com/495354

this will be part of 0.8.36.4+

►

Issue 718258 link

Issue metadata

nassh: add IDNA support

Issue description

Comment 1 by bugdroid1@chromium.org, May 9 2017

Comment 1 Deleted

Comment 2 by vapier@chromium.org, May 10 2017

Comment 2 Deleted

Sign in to add a comment