New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 718236 link

Starred by 1 user
Status: Fixed
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
pfeldman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Finalize network's use of product registry

Project Member Reported by allada@chromium.org, May 3 2017 
We need to finalize on the exact use/look of product registry for network panel.

After a talk with pfeldman@, we decided to go with:

* If a request is from a frame we colorize it blue.
* If a request is a product we colorize it yellow.
* Product column will be the name of the frame (if it has a frame name) and fall back to a product of the individual request otherwise blank.
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed10e8d7378176b6346982f08e0930d18069f99e

commit ed10e8d7378176b6346982f08e0930d18069f99e
Author: allada <allada@chromium.org>
Date: Fri May 05 03:15:02 2017

[Devtools] Restructure network nodes for friendlier products/grouping

Restructures how NetworkNodes are managed to push more of the code into
the individual implementations of the NetworkGrouper. Grouper is now
more like a factory for a NetworkNode.

In the case here, we are setting up FrameGroupNode as an extension of
NetworkGroupNode which is a lightweight wrapper for groupable items.
When a cell is being rendered we are now able to intercept the calls and
render them with special content (like we do here with product and name
column).

R=pfeldman,dgozman
BUG= 718236 

Review-Url: https://codereview.chromium.org/2859063003
Cr-Commit-Position: refs/heads/master@{#469583}

[modify] https://crrev.com/ed10e8d7378176b6346982f08e0930d18069f99e/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/ed10e8d7378176b6346982f08e0930d18069f99e/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[add] https://crrev.com/ed10e8d7378176b6346982f08e0930d18069f99e/third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js
[delete] https://crrev.com/32a9e92ea1f387e91a9f7b87e19ce48f3990404c/third_party/WebKit/Source/devtools/front_end/network/NetworkGroupers.js
[modify] https://crrev.com/ed10e8d7378176b6346982f08e0930d18069f99e/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/ed10e8d7378176b6346982f08e0930d18069f99e/third_party/WebKit/Source/devtools/front_end/network/module.json
[modify] https://crrev.com/ed10e8d7378176b6346982f08e0930d18069f99e/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
[modify] https://crrev.com/ed10e8d7378176b6346982f08e0930d18069f99e/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

Comment 2 by allada@chromium.org, Jul 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment