New issue
Advanced search Search tips

Issue 718235 link

Starred by 21 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Chrome Headless discards alerts an prompts

Project Member Reported by lushnikov@chromium.org, May 3 2017

Issue description

Chrome Headless discards alerts and prompts by default. Is this intentional?

This makes it impossible to handle prompt/confirm dialogs properly via the remote protocol's handleJavaScriptDialog method.
 
Owner: alexclarke@chromium.org
Status: Assigned (was: Unconfirmed)
Owner: ----
Status: Available (was: Assigned)
No that sounds like something that should be changed.
Components: Internals>Headless
 Issue chromedriver:1847  has been merged into this issue.
 Issue chromedriver:1881  has been merged into this issue.

Comment 6 Deleted

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c1842b725c3dd24822f7663ef407b5a556a29c5

commit 3c1842b725c3dd24822f7663ef407b5a556a29c5
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Wed Aug 02 05:00:16 2017

DevTools: dispatch jsdialog-related events regardless of the embedder dialog delegate.

Bug:  718235 
Change-Id: I39d763bec2a12ff2e77e67e201c1137983a8dc00
Reviewed-on: https://chromium-review.googlesource.com/592608
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491272}
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/content/browser/web_contents/web_contents_impl.h
[delete] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/third_party/WebKit/LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt
[delete] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/third_party/WebKit/LayoutTests/inspector-protocol/page/javascriptDialogEvents.js
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/third_party/WebKit/Source/core/page/ChromeClient.cpp
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/third_party/WebKit/Source/core/probe/CoreProbes.pidl
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[modify] https://crrev.com/3c1842b725c3dd24822f7663ef407b5a556a29c5/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

Cc: pfeldman@chromium.org
Should this be marked as fixed now?
Status: Fixed (was: Available)
Works great, thanks! 
Any idea on when is this fix going to be released? Thanks in advance.
Same question here. When will this fix be released?
This is still happening in Chrome 61.0.3163.91 in headless mode

Comment 13 Deleted

It'll be in 62.0.3175.0 and above.
But when it will be released approx?

Comment 17 by tymf...@gmail.com, Oct 2 2017

Waiting for it!
It is not still not working in Chromium 70.0 and puppeteer 1.7.0 in windows.

Sign in to add a comment