StyleRareInheritedData.h only partially renamed. |
|||
Issue descriptionIn https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/style/StyleRareInheritedData.h , members like 'text_align_last_' have the correct style, but 'text_security' do not. It is unclear why there's an inconsistency here.
,
May 10 2017
Hi dcheng, is there a tool that I can use to quickly do the rename myself?
,
May 10 2017
It's still checked in at tools/rename_to_chrome_style and high-level instructions on running clang tools are in https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tool_refactoring.md, but can I ask what you're trying to do?
,
May 10 2017
Cool, I'm just renaming things like 'text_security' to 'text_security_' in StyleRareInheritedData.
,
May 10 2017
FWIW, if the tool didn't handle it completely correctly the first time, it probably won't help for followups.
,
May 11 2017
Oh I see. That's so weird, do you have any idea about why only like half the members were renamed?
,
May 11 2017
I am guessing that the tool added a trailing underscore to old variables that were prefixed with m_ (e.g. |m_imageRendering| -> |image_rendering_|) but didn't add a trailing underscore to other names (e.g. |textEmphasisMark| -> |text_emphasis_mark|).
,
May 11 2017
Okay, I'm probably just rename it myself without the tool then if that's okay :)
,
May 11 2017
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd5e51ff504a52903dd0fd6ec2d37b9940e658bf commit dd5e51ff504a52903dd0fd6ec2d37b9940e658bf Author: shend <shend@chromium.org> Date: Thu May 11 09:55:23 2017 Rename members in StyleRareInheritedData. This patch renames some members in StyleRareInheritedData to conform to the new Blink style. BUG= 718214 Review-Url: https://codereview.chromium.org/2874123002 Cr-Commit-Position: refs/heads/master@{#470894} [modify] https://crrev.com/dd5e51ff504a52903dd0fd6ec2d37b9940e658bf/third_party/WebKit/Source/core/style/ComputedStyle.cpp [modify] https://crrev.com/dd5e51ff504a52903dd0fd6ec2d37b9940e658bf/third_party/WebKit/Source/core/style/ComputedStyle.h [modify] https://crrev.com/dd5e51ff504a52903dd0fd6ec2d37b9940e658bf/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp [modify] https://crrev.com/dd5e51ff504a52903dd0fd6ec2d37b9940e658bf/third_party/WebKit/Source/core/style/StyleRareInheritedData.h
,
May 15 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dcheng@chromium.org
, May 3 2017