New issue
Advanced search Search tips

Issue 718214 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 675877



Sign in to add a comment

StyleRareInheritedData.h only partially renamed.

Project Member Reported by shend@chromium.org, May 3 2017

Issue description

In https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/style/StyleRareInheritedData.h , members like 'text_align_last_' have the correct style, but 'text_security' do not. It is unclear why there's an inconsistency here.
 
Cc: lukasza@chromium.org

Comment 2 by shend@chromium.org, May 10 2017

Hi dcheng, is there a tool that I can use to quickly do the rename myself?

Comment 3 by dcheng@chromium.org, May 10 2017

It's still checked in at tools/rename_to_chrome_style and high-level instructions on running clang tools are in https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tool_refactoring.md, but can I ask what you're trying to do?

Comment 4 by shend@chromium.org, May 10 2017

Cool, I'm just renaming things like 'text_security' to 'text_security_' in StyleRareInheritedData.

Comment 5 by dcheng@chromium.org, May 10 2017

FWIW, if the tool didn't handle it completely correctly the first time, it probably won't help for followups.

Comment 6 by shend@chromium.org, May 11 2017

Oh I see. That's so weird, do you have any idea about why only like half the members were renamed?
I am guessing that the tool added a trailing underscore to old variables that were prefixed with m_ (e.g. |m_imageRendering| -> |image_rendering_|) but didn't add a trailing underscore to other names (e.g. |textEmphasisMark| -> |text_emphasis_mark|).

Comment 8 by shend@chromium.org, May 11 2017

Okay, I'm probably just rename it myself without the tool then if that's okay :)

Comment 9 by shend@chromium.org, May 11 2017

Owner: shend@chromium.org
Status: Assigned (was: Untriaged)

Comment 11 by shend@chromium.org, May 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment